[jira] [Created] (HBASE-21950) build hbase in the lower git version, revision is not correct

["xuqinya (JIRA)" <ji...@apache.org>]

xuqinya created HBASE-21950:
-------------------------------

             Summary: build hbase in the lower git version, revision is not correct 
                 Key: HBASE-21950
                 URL: https://issues.apache.org/jira/browse/HBASE-21950
             Project: HBase
          Issue Type: Bug
            Reporter: xuqinya


HBASE-20764 solved the problem of revision generation when somebody has log.showsignature=true in their local gitconfig and latest commit is gpg signed.
saveVersion.sh

{code:java}
revision=`git log -1 --no-show-signature --pretty=format:"%H"
{code}
But, --no-show-signature in git version 2.10 or higher. In the lower version, compiling hbase will not generate correct revision. Is this a problem?

{code:java}
[hadoop@hadoop1 hbase]$ git log -1 --no-show-signature --pretty=format:"%H"
fatal: unrecognized argument: --no-show-signature
[hadoop@hadoop1 hbase]$ git --version
git version 1.8.3.1
{code}
hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java

{code:java}
 1 /*
  2  * Generated by src/saveVersion.sh
  3  */
  4 package org.apache.hadoop.hbase;
  5 
  6 import org.apache.yetus.audience.InterfaceAudience;
  7 
  8 @InterfaceAudience.Private
  9 public class Version {
 10   public static final String version = "3.0.0-SNAPSHOT";
 11   public static final String revision = "";
 12   public static final String user = "hadoop";
 13   public static final String date = "Mon Feb 25 12:57:23 CST 2019";
 14   public static final String url = "git://hadoop1/home/hadoop/git/hbase";
 15   public static final String srcChecksum = "809d2258de4992d54f06110f9e7f3e8e";
 16 }
{code}





--
This message was sent by Atlassian JIRA
(v7.6.3#76005)