[GitHub] [spark] cloud-fan commented on a change in pull request #27750: [SPARK-30998][SQL] ClassCastException when a generator having nested inner generators

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #27750: [SPARK-30998][SQL] ClassCastException when a generator having nested inner generators
URL: https://github.com/apache/spark/pull/27750#discussion_r386211118
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ##########
 @@ -2164,10 +2164,19 @@ class Analyzer(
     }
 
     private def hasNestedGenerator(expr: NamedExpression): Boolean = {
+      def hasUnsupportedInnerGenerator(g: Generator): Boolean = g match {
+        case go: GeneratorOuter => // The only case that can have an inner generator
 
 Review comment:
   seems `GeneratorOuter` is just a wrapper not a real `Generator`, so it doesn't count when checking nested generators. Shall we make the comment more clear?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org