You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2018/06/29 20:35:00 UTC

[jira] [Commented] (HBASE-20826) Truncate responseInfo attributes on RpcServer WARN messages

    [ https://issues.apache.org/jira/browse/HBASE-20826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528201#comment-16528201 ] 

Ted Yu commented on HBASE-20826:
--------------------------------

lgtm

Maybe the LOG.isTraceEnabled() check can be removed. Otherwise log file would be filled fast in TRACE mode.

> Truncate responseInfo attributes on RpcServer WARN messages
> -----------------------------------------------------------
>
>                 Key: HBASE-20826
>                 URL: https://issues.apache.org/jira/browse/HBASE-20826
>             Project: HBase
>          Issue Type: Improvement
>          Components: rpc
>            Reporter: Sergey Soldatov
>            Assignee: Josh Elser
>            Priority: Major
>             Fix For: 3.0.0, 2.1.0, 2.0.2, 2.2.0
>
>         Attachments: HBASE-20826.001.branch-2.0.patch
>
>
> With Phoenix in the picture, dumping the {{Call}} protobuf to the RS log can get *really* chatty, real fast. Notably, some serialized filters just spam the log with binary garbage.
> Let's add an upper-limit to the length of params we'll put out at WARN, and leave the full content for TRACE.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)