You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by dguy <gi...@git.apache.org> on 2016/09/19 08:56:06 UTC

[GitHub] kafka pull request #1879: HOTFIX: logic in QuerybaleStateIntegrationTest.sho...

GitHub user dguy opened a pull request:

    https://github.com/apache/kafka/pull/1879

    HOTFIX: logic in QuerybaleStateIntegrationTest.shouldBeAbleToQueryState incorrect

    The logic in `verifyCanGetByKey` was incorrect. It was 
    ```
    windowState.size() < keys.length &&
    countState.size() < keys.length &&
    System.currentTimeMillis() < timeout
    ```
    but should be:
    ```
    (windowState.size() < keys.length || countState.size() < keys.length) && System.currentTimeMillis() < timeout
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dguy/kafka minor-fix-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1879.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1879
    
----
commit d9eb06b407ad9d25ee037752eb533000f4e68630
Author: Damian Guy <da...@gmail.com>
Date:   2016-09-19T08:48:37Z

    logic in test incorrect

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #1879: HOTFIX: logic in QuerybaleStateIntegrationTest.sho...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/1879


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---