[GitHub] [aurora] rdelval commented on a change in pull request #54: Auto Pause for Batch based update strategies

[GitBox <gi...@apache.org>]

rdelval commented on a change in pull request #54: Auto Pause for Batch based update strategies
URL: https://github.com/apache/aurora/pull/54#discussion_r317367779
 
 

 ##########
 File path: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
 ##########
 @@ -133,6 +138,11 @@
   private final Map<IJobKey, UpdateFactory.Update> updates =
       Collections.synchronizedMap(Maps.newHashMap());
 
+  // Used only for updates that have auto pause enabled. Keeps track of what instances
+  // have already been seen by the updater in order to detect when a new batch is started.
+  private final Map<IJobUpdateKey, Set<Integer>> instancesSeen =
+      new ConcurrentHashMap<IJobUpdateKey, Set<Integer>>();
 
 Review comment:
   Good catch!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services