[GitHub] [skywalking-query-protocol] mrproliu commented on a diff in pull request #109: Add continuous profiling feature related query protocol

["mrproliu (via GitHub)" <gi...@apache.org>]

mrproliu commented on code in PR #109:
URL: https://github.com/apache/skywalking-query-protocol/pull/109#discussion_r1121391561


##########
ebpf-profiling.graphqls:
##########
@@ -225,7 +272,7 @@ extend type Query {
     # query eBPF profiling data for prepare create task
     queryPrepareCreateEBPFProfilingTaskData(serviceId: ID!): EBPFProfilingTaskPrepare!
     # query eBPF profiling task list
-    queryEBPFProfilingTasks(serviceId: ID, serviceInstanceId: ID, targets: [EBPFProfilingTargetType!]): [EBPFProfilingTask!]!
+    queryEBPFProfilingTasks(serviceId: ID, serviceInstanceId: ID, targets: [EBPFProfilingTargetType!], triggerType: EBPFProfilingTriggerType, duration: Duration): [EBPFProfilingTask!]!

Review Comment:
   `duration` provide the filter for which task start time is matched. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org