[jira] [Commented] (BEAM-210) Be consistent with emitting final empty panes

["Mark Shields (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248353#comment-15248353 ] 

Mark Shields commented on BEAM-210:
-----------------------------------

Hang on, our diagnosis is wrong, the test *is* on all paths.
However, it is (currently) WAI to have an empty ON_TIME pane irrespective of the closingBehavior setting.  

Alex, could you give us more details on what the user is seeing? 

> Be consistent with emitting final empty panes
> ---------------------------------------------
>
>                 Key: BEAM-210
>                 URL: https://issues.apache.org/jira/browse/BEAM-210
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Mark Shields
>            Assignee: Mark Shields
>
> Currently ReduceFnRunner.onTrigger uses shouldEmit to prevent empty final panes unless the user has requested them.
> The same check needs to be done in ReduceFnRunner.onTimer



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)