You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/10/11 01:04:18 UTC

[GitHub] [skywalking] jsbxyyx edited a comment on issue #3570: test: add oap-server core alarm package test case

jsbxyyx edited a comment on issue #3570: test: add oap-server core alarm package test case
URL: https://github.com/apache/skywalking/pull/3570#issuecomment-540857189
 
 
   > The method names is not as what we discussed in [#3552 (comment)](https://github.com/apache/skywalking/pull/3552#discussion_r329522793)
   > 
   > I'm ok with this PR @wu-sheng , considering that @jsbxyyx you will contribute more test, please pay special attention to what we've discussed, :) thanks
   
   Before, the conclusion is do not use `_` ?  style is it like this `methodNameDoesWhatWhenTheseConditions`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services