You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/04/23 08:17:31 UTC
[GitHub] [cloudstack-kubernetes-provider] onitake opened a new pull request #27: Provider should not be a DaemonSet
onitake opened a new pull request #27:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27
I mistakenly wrote in the readme that the provider should be DaemonSet.
This is wrong and should be removed.
The example deployment.yaml is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #27: Provider should not be a DaemonSet
Posted by GitBox <gi...@apache.org>.
onitake commented on pull request #27:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-827637589
3+ replicas of the cloud provider seems like total overkill.
It doesn't store any state, and it doesn't need to be highly available. It will synchronize to the environment on startup anyway.
This PR is only about the DaemonSet, however. That line in the documentation is no longer relevant and should be removed before 1.0 is released.
@davidjumani Can you open a separate issue to discuss the example deployment (number of replicas, recommendations, etc.)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #27: Provider should not be a DaemonSet
Posted by GitBox <gi...@apache.org>.
onitake commented on pull request #27:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-826630266
Not really. The original CCM needed to have an instance on each node, to interact with the host system.
This is no longer the case with the cloud provider - a single instance that listens for LoadBalancer deployments and Node registration is enough. If that instance crashes, the cluster will relaunch it anyway.
@joschi36 Please correct me if I'm wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #27: Provider should not be a DaemonSet
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #27:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-826537469
@onitake wouldn't it be better if it was run as a daemonset ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #27: Provider should not be a DaemonSet
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #27:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-827556759
@onitake Agreed, but in the case of a smaller env, there will be 3 pods on maybe 1 or 2 nodes. I'd prefer to have the replicas proportional to the nodes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #27: Provider should not be a DaemonSet
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #27:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-828134518
@rhtyd Can you merge ?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #27: Provider should not be a DaemonSet
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #27:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-826537469
@onitake wouldn't it be better if it was run as a daemonset ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani edited a comment on pull request #27: Provider should not be a DaemonSet
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #27:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-827556759
@onitake Agreed so not necessarily a deamonset, but in the case of a smaller env, there will be 3 pods on maybe 1 or 2 nodes, since most users will just apply the deployment. I'd prefer to have the replicas proportional to the nodes.
I plan to add this as an automatic deployment as part of a CKS cluster creation once it's officially released
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rhtyd merged pull request #27: Provider should not be a DaemonSet
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #27:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #27: Provider should not be a DaemonSet
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #27:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-828134379
Right, unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani edited a comment on pull request #27: Provider should not be a DaemonSet
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #27:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-827556759
@onitake Agreed so not necessarily a deamonset, but in the case of a smaller env, there will be 3 pods on maybe 1 or 2 nodes. I'd prefer to have the replicas proportional to the nodes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org