[GitHub] [ignite-3] rpuch commented on a diff in pull request #2134: IGNITE-19596 Partition creation fails with NSFE

["rpuch (via GitHub)" <gi...@apache.org>]

rpuch commented on code in PR #2134:
URL: https://github.com/apache/ignite-3/pull/2134#discussion_r1214215024


##########
modules/page-memory/src/test/java/org/apache/ignite/internal/pagememory/persistence/store/FilePageStoreManagerTest.java:
##########
@@ -440,13 +449,68 @@ void testFullyRemovePartitionOnStart() throws Exception {
         );
     }
 
+    @ParameterizedTest
+    @ValueSource(ints = {1, 2, 4, 10, 25, 50})

Review Comment:
   Let's add a sane time out (like `@Timeout(value = 1, unit = MINUTE)`) just in case as racers use potentially infinite loops (if something gets broken in the future, they could hang forever)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org