You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2020/03/03 21:06:05 UTC
Re: Review Request 72136: RANGER-2723: Support ldap attribute based
document level control for solr plugin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72136/
-----------------------------------------------------------
(Updated March 3, 2020, 9:06 p.m.)
Review request for ranger, Abhay Kulkarni, Ramesh Mani, and Velmurugan Periasamy.
Changes
-------
Incorporated review comments
Bugs: RANGER-2723
https://issues.apache.org/jira/browse/RANGER-2723
Repository: ranger
Description
-------
Added new context enricher to download userstore to solr plugin. Also integrated Sentry changes to RangerSolrAuthorizer to use the ldap attributes and add it to the filter query to while querying documents in solr.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/admin/client/AbstractRangerAdminClient.java 87d0190e6
agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminClient.java 58eb00a4e
agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java e5f97477b
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAdminUserStoreRetriever.java PRE-CREATION
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerUserStoreEnricher.java PRE-CREATION
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerUserStoreRetriever.java PRE-CREATION
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java bd980ce09
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java 0b492ab99
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/FieldToAttributeMapping.java PRE-CREATION
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java 4538a5bf2
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/SubsetQueryPlugin.java PRE-CREATION
Diff: https://reviews.apache.org/r/72136/diff/2/
Changes: https://reviews.apache.org/r/72136/diff/1-2/
Testing
-------
1. Patched test cluster and verified userstore is download to solr plugin
2. Also verified basic funtionality based on some ldap attributes while querying solr documents.
Thanks,
Sailaja Polavarapu
Re: Review Request 72136: RANGER-2723: Support ldap attribute based
document level control for solr plugin
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72136/#review219853
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On March 3, 2020, 9:06 p.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72136/
> -----------------------------------------------------------
>
> (Updated March 3, 2020, 9:06 p.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2723
> https://issues.apache.org/jira/browse/RANGER-2723
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Added new context enricher to download userstore to solr plugin. Also integrated Sentry changes to RangerSolrAuthorizer to use the ldap attributes and add it to the filter query to while querying documents in solr.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/admin/client/AbstractRangerAdminClient.java 87d0190e6
> agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminClient.java 58eb00a4e
> agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java e5f97477b
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAdminUserStoreRetriever.java PRE-CREATION
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerUserStoreEnricher.java PRE-CREATION
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerUserStoreRetriever.java PRE-CREATION
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java bd980ce09
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java 0b492ab99
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/FieldToAttributeMapping.java PRE-CREATION
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java 4538a5bf2
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/SubsetQueryPlugin.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72136/diff/2/
>
>
> Testing
> -------
>
> 1. Patched test cluster and verified userstore is download to solr plugin
> 2. Also verified basic funtionality based on some ldap attributes while querying solr documents.
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>