You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by th...@apache.org on 2020/09/14 16:38:49 UTC
[lucene-solr] 31/39: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an… (#1830)
This is an automated email from the ASF dual-hosted git repository.
thelabdude pushed a commit to branch reference_impl_gradle_updates
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
commit e952c4fa226f6b3bdd32812a8bd47f4070873867
Author: Dawid Weiss <da...@carrotsearch.com>
AuthorDate: Tue Sep 8 10:08:51 2020 +0200
LUCENE-9506: Gradle: split validateSourcePatterns into per-project an… (#1830)
* LUCENE-9506: Gradle: split validateSourcePatterns into per-project and root-specific tasks (allow parallelism)
Co-authored-by: Uwe Schindler <us...@apache.org>
---
gradle/validation/precommit.gradle | 5 ++---
gradle/validation/validate-log-calls.gradle | 5 ++++-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/gradle/validation/precommit.gradle b/gradle/validation/precommit.gradle
index aad8c6f0..e4de4be 100644
--- a/gradle/validation/precommit.gradle
+++ b/gradle/validation/precommit.gradle
@@ -26,7 +26,6 @@ configure(rootProject) {
dependsOn ":verifyLocks"
dependsOn ":versionsPropsAreSorted"
dependsOn ":checkWorkingCopyClean"
- dependsOn ":validateSourcePatterns"
// Solr validation tasks.
dependsOn ":solr:validateConfigFileSanity"
@@ -40,8 +39,8 @@ configure(rootProject) {
"javadoc",
"rat",
"ecjLint",
- "checkMissingDocs",
- "validateLogCalls"
+ "validateLogCalls",
+ "validateSourcePatterns",
]}
}
}
diff --git a/gradle/validation/validate-log-calls.gradle b/gradle/validation/validate-log-calls.gradle
index 3d0566a..caa6f5e 100644
--- a/gradle/validation/validate-log-calls.gradle
+++ b/gradle/validation/validate-log-calls.gradle
@@ -45,7 +45,10 @@ configure(subprojects.findAll { it.path.startsWith(':solr') }) {
sourceFiles = files(sourceSets*.java)
}
- }
+
+ // Add log validation to per-project checks as well.
+ check.dependsOn validateLogCalls
+ }
}
class ValidateLogCallsTask extends DefaultTask {