You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by wuzhouhui <wu...@mails.ucas.ac.cn> on 2019/12/15 10:02:50 UTC
quilt-like feature, to support patch series
Hi,
Can Subversion support patch series, like quilt. So I can split a
big change to small pieces before submit all of them, and post-commit
review will be more easy.
Thanks.
Re: quilt-like feature, to support patch series
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
wuzhouhui wrote on Tue, 17 Dec 2019 04:38 +00:00:
> From: "Daniel Shahaf" <d....@daniel.shahaf.name>
> > To do this, I guess you'll want to write a script that automatically
> > commits a patch series along with log messages (from `quilt header -e`)?
> > If you do, please consider publishing it; it's not the first time this
> > question has come up so it'll probably be useful to others.
> I'm going to hack Subversion, instead of quilt.
I think there's been a misunderstanding: I didn't propose that you modify
quilt. In any case, if you have something reusable, please post it :)
Re: Re: quilt-like feature, to support patch series
Posted by wuzhouhui <wu...@mails.ucas.ac.cn>.
> -----Original Messages-----
> From: "Daniel Shahaf" <d....@daniel.shahaf.name>
> Sent Time: 2019-12-17 09:29:22 (Tuesday)
> To: wuzhouhui <wu...@mails.ucas.ac.cn>
> Cc: subversion <us...@subversion.apache.org>
> Subject: Re: quilt-like feature, to support patch series
>
> wuzhouhui wrote on Mon, 16 Dec 2019 06:57 +00:00:
> > I don't want to commit changes until I think the changes are good enough. After
> > all, commit to a branch is also a commit.
>
> There is no technical requirement that commits to branches be as stable
> as commits to trunk; that's purely a social construct and, as such,
> subject to change. For example, in Subversion's own development we
> explicitly encourage not-necessarily-fully-baked commits, but ask that
> they be clearly labeled in the log message; see
> https://subversion.apache.org/docs/community-guide/conventions.html#log-messages
> (last three paragraphs only). Or you could make the distinction based on the
> branch's URL, etc..
>
> > > You could also use git-svn(1) local branches, for example. Or you could use
> > > quilt on top of Subversion.
> >
> > Using quilt on top of Subversion seems is a good idea.
>
> To do this, I guess you'll want to write a script that automatically
> commits a patch series along with log messages (from `quilt header -e`)?
> If you do, please consider publishing it; it's not the first time this
> question has come up so it'll probably be useful to others.
I'm going to hack Subversion, instead of quilt.
>
> Cheers,
>
> Daniel
Re: quilt-like feature, to support patch series
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
wuzhouhui wrote on Mon, 16 Dec 2019 06:57 +00:00:
> I don't want to commit changes until I think the changes are good enough. After
> all, commit to a branch is also a commit.
There is no technical requirement that commits to branches be as stable
as commits to trunk; that's purely a social construct and, as such,
subject to change. For example, in Subversion's own development we
explicitly encourage not-necessarily-fully-baked commits, but ask that
they be clearly labeled in the log message; see
https://subversion.apache.org/docs/community-guide/conventions.html#log-messages
(last three paragraphs only). Or you could make the distinction based on the
branch's URL, etc..
> > You could also use git-svn(1) local branches, for example. Or you could use
> > quilt on top of Subversion.
>
> Using quilt on top of Subversion seems is a good idea.
To do this, I guess you'll want to write a script that automatically
commits a patch series along with log messages (from `quilt header -e`)?
If you do, please consider publishing it; it's not the first time this
question has come up so it'll probably be useful to others.
Cheers,
Daniel
Re: Re: quilt-like feature, to support patch series
Posted by wuzhouhui <wu...@mails.ucas.ac.cn>.
> -----Original Messages-----
> From: "Daniel Shahaf" <d....@daniel.shahaf.name>
> Sent Time: 2019-12-16 12:37:07 (Monday)
> To: wuzhouhui <wu...@mails.ucas.ac.cn>
> Cc: Subversion <us...@subversion.apache.org>
> Subject: Re: quilt-like feature, to support patch series
>
> Nathan Hartman wrote on Sun, Dec 15, 2019 at 22:06:03 -0500:
> > On Sun, Dec 15, 2019 at 5:03 AM wuzhouhui <wu...@mails.ucas.ac.cn>
> > wrote:
> >
> > > Hi,
> > >
> > > Can Subversion support patch series, like quilt. So I can split a
> > > big change to small pieces before submit all of them, and post-commit
> > > review will be more easy.
> >
> >
> > Not yet. (At least not that I know of.)
> >
> > Can you use a branch and later merge the branch?
I don't want to commit changes until I think the changes are good enough. After
all, commit to a branch is also a commit.
>
> You could also use git-svn(1) local branches, for example. Or you could use
> quilt on top of Subversion.
Using quilt on top of Subversion seems is a good idea.
Re: quilt-like feature, to support patch series
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Nathan Hartman wrote on Sun, Dec 15, 2019 at 22:06:03 -0500:
> On Sun, Dec 15, 2019 at 5:03 AM wuzhouhui <wu...@mails.ucas.ac.cn>
> wrote:
>
> > Hi,
> >
> > Can Subversion support patch series, like quilt. So I can split a
> > big change to small pieces before submit all of them, and post-commit
> > review will be more easy.
>
>
> Not yet. (At least not that I know of.)
>
> Can you use a branch and later merge the branch?
You could also use git-svn(1) local branches, for example. Or you could use
quilt on top of Subversion.
Re: quilt-like feature, to support patch series
Posted by Nathan Hartman <ha...@gmail.com>.
On Sun, Dec 15, 2019 at 5:03 AM wuzhouhui <wu...@mails.ucas.ac.cn>
wrote:
> Hi,
>
> Can Subversion support patch series, like quilt. So I can split a
> big change to small pieces before submit all of them, and post-commit
> review will be more easy.
Not yet. (At least not that I know of.)
Can you use a branch and later merge the branch?
Re: quilt-like feature, to support patch series
Posted by Paul Hammant <pa...@hammant.org>.
Subversion's missing piece is the patch-review system, agreed. Rietveld
was 11.5 years ago (and Mondrian was 2 years before that - Perforce
admittedly), so we have plenty of things to be inspired by. In the last
year a "shelve" facility has been perfected for Subversion -
https://cwiki.apache.org/confluence/display/SVN/Shelving-v3+in+Svn-1.12. It
seems to me that this could be grown into a patch review system.
Ref: https://en.wikipedia.org/wiki/Rietveld_(software)