You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2022/06/23 12:28:34 UTC

[Impala-ASF-CR] IMPALA-10895: Fix flakiness of test retrying query cancel

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18659

Change subject: IMPALA-10895: Fix flakiness of test_retrying_query_cancel
......................................................................

IMPALA-10895: Fix flakiness of test_retrying_query_cancel

test_retrying_query_cancel test canceling the query when it's in the
RETRYING state. The test first run the query and wait for the state
become RETRYING. There is a debug action added to make the RETRYING
state longer than 1s, so it can be sufficient in the test. However, when
waiting for the RETRYING state, the interval is 0.5s. This waste the
majority of the time. In ASAN builds, the time is not enough for the
following steps, resulting the query state become RETRIED and fail the
test.

This patch reduces the wait interval to 0.1s. Also add some logs and
modify the code to get state after the wait instead of before the wait.

Tests:
- Run the test more than 1000 times in an ASAN build. Before this patch
it fails in around 30 runs.

Change-Id: Id069091c94160d09868fcdc36ac7195b1deb337a
---
M tests/custom_cluster/test_query_retries.py
1 file changed, 4 insertions(+), 2 deletions(-)

git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/18659/1
--
To view, visit http://gerrit.cloudera.org:8080/18659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id069091c94160d09868fcdc36ac7195b1deb337a
Gerrit-Change-Number: 18659
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-10895: Fix flakiness of test retrying query cancel

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18659 )

Change subject: IMPALA-10895: Fix flakiness of test_retrying_query_cancel
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8265/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id069091c94160d09868fcdc36ac7195b1deb337a
Gerrit-Change-Number: 18659
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 23:45:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10895: Fix flakiness of test retrying query cancel

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18659 )

Change subject: IMPALA-10895: Fix flakiness of test_retrying_query_cancel
......................................................................

IMPALA-10895: Fix flakiness of test_retrying_query_cancel

This patch reduces the wait interval to 0.1s. Also add some logs and
modify the code to get state after the wait instead of before the wait.

Tests:
- Run the test more than 1000 times in an ASAN build. Before this patch
it fails in around 30 runs.

Change-Id: Id069091c94160d09868fcdc36ac7195b1deb337a
Reviewed-on: http://gerrit.cloudera.org:8080/18659
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_query_retries.py
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/18659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id069091c94160d09868fcdc36ac7195b1deb337a
Gerrit-Change-Number: 18659
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-10895: Fix flakiness of test retrying query cancel

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18659 )

Change subject: IMPALA-10895: Fix flakiness of test_retrying_query_cancel
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10845/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id069091c94160d09868fcdc36ac7195b1deb337a
Gerrit-Change-Number: 18659
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 12:48:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10895: Fix flakiness of test retrying query cancel

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18659 )

Change subject: IMPALA-10895: Fix flakiness of test_retrying_query_cancel
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id069091c94160d09868fcdc36ac7195b1deb337a
Gerrit-Change-Number: 18659
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Jun 2022 04:25:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10895: Fix flakiness of test retrying query cancel

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.

Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18659 )

Change subject: IMPALA-10895: Fix flakiness of test_retrying_query_cancel
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id069091c94160d09868fcdc36ac7195b1deb337a
Gerrit-Change-Number: 18659
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 16:00:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10895: Fix flakiness of test retrying query cancel

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18659 )

Change subject: IMPALA-10895: Fix flakiness of test_retrying_query_cancel
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id069091c94160d09868fcdc36ac7195b1deb337a
Gerrit-Change-Number: 18659
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 23:45:40 +0000
Gerrit-HasComments: No