You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mgaido91 <gi...@git.apache.org> on 2018/01/23 16:10:14 UTC
[GitHub] spark pull request #20364: [SPARK-23166][ML] Add maxDF to CountVectorizer
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/20364
[SPARK-23166][ML] Add maxDF to CountVectorizer
## What changes were proposed in this pull request?
It might be useful to also have a maxDF parameter in CountVectorizer.
It might be used as a threshold for filtering all the terms that occur very frequently in a text corpus, because they are not very informative or could even be stop-words.
This is analogous to scikit-learn, CountVectorizer, max_df.
## How was this patch tested?
added UTs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mgaido91/spark SPARK-23166
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20364.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20364
----
commit f01f1cabbed710301fd6837a101f36f2c5d8e1fc
Author: Marco Gaido <ma...@...>
Date: 2018-01-23T15:54:12Z
[SPARK-23166][ML] Add maxDF to CountVectorizer
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20364: [SPARK-23166][ML] Add maxDF to CountVectorizer
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20364
**[Test build #86534 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86534/testReport)** for PR 20364 at commit [`f01f1ca`](https://github.com/apache/spark/commit/f01f1cabbed710301fd6837a101f36f2c5d8e1fc).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20364: [SPARK-23166][ML] Add maxDF to CountVectorizer
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20364
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86534/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20364: [SPARK-23166][ML] Add maxDF to CountVectorizer
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 closed the pull request at:
https://github.com/apache/spark/pull/20364
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20364: [SPARK-23166][ML] Add maxDF to CountVectorizer
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20364
**[Test build #86534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86534/testReport)** for PR 20364 at commit [`f01f1ca`](https://github.com/apache/spark/commit/f01f1cabbed710301fd6837a101f36f2c5d8e1fc).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20364: [SPARK-23166][ML] Add maxDF to CountVectorizer
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20364
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/145/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20364: [SPARK-23166][ML] Add maxDF to CountVectorizer
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20364
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20364: [SPARK-23166][ML] Add maxDF to CountVectorizer
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20364
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org