You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/03/25 20:46:35 UTC

[GitHub] [incubator-iceberg] mccheah edited a comment on issue #143: Applies the Baseline plugin for iceberg-api only.

mccheah edited a comment on issue #143: Applies the Baseline plugin for iceberg-api only.
URL: https://github.com/apache/incubator-iceberg/pull/143#issuecomment-476370423
 
 
   > Looks like Baseline will indeed give us ./gradlew idea and ./gradlew eclipse to import the guidelines to IDEs: https://github.com/palantir/gradle-baseline#compalantirbaseline-idea
   
   The default project configuration given by Baseline adheres to the default project style guidelines Baseline is opinionated about. I changed the default project configuration to match as many of the style guideline deviations as I could remember here, but there might be cases where the generated IDEA project doesn't match what we changed in `checkstyle.xml`. The main style setup I changed in the IDEA project were license headers, indentation numbers, and import ordering (static vs. non-static). I think we'll have to unfortunately catch the other deviations we made on a case by case basis moving forward.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org