[jira] [Comment Edited] (YARN-4925) ContainerRequest in AMRMClient, application should be able to specify nodes/racks together with nodeLabelExpression

["Naganarasimha G R (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-4925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289412#comment-15289412 ] 

Naganarasimha G R edited comment on YARN-4925 at 5/18/16 5:44 PM:
------------------------------------------------------------------

Committed it to branch 2.8, branch 2 & trunk, Thanks for working on this patch [~bibinchundatt] and [~sunilg] for the review.


was (Author: naganarasimha):
Committed it to branch 2.8, branch 2 & Thanks for working on this patch 

> ContainerRequest in AMRMClient, application should be able to specify nodes/racks together with nodeLabelExpression
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-4925
>                 URL: https://issues.apache.org/jira/browse/YARN-4925
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>         Attachments: 0001-YARN-4925.patch, 0002-YARN-4925.patch
>
>
> Currently with nodelabel AMRMClient will not be able to specify nodelabels with Node/Rack requests.For application like spark NODE_LOCAL requests cannot be asked with label expression.
> As per the check in  {{AMRMClientImpl#checkNodeLabelExpression}}
> {noformat}
>     // Don't allow specify node label against ANY request
>     if ((containerRequest.getRacks() != null && 
>         (!containerRequest.getRacks().isEmpty()))
>         || 
>         (containerRequest.getNodes() != null && 
>         (!containerRequest.getNodes().isEmpty()))) {
>       throw new InvalidContainerRequestException(
>           "Cannot specify node label with rack and node");
>     }
> {noformat}
> {{AppSchedulingInfo#updateResourceRequests}} we do reset of labels to that of OFF-SWITCH. 
> The above check is not required for ContainerRequest ask /cc [~wangda] thank you for confirming



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org