You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Eric Newton <er...@gmail.com> on 2015/01/06 22:41:16 UTC
Re: Review Request 29230: ACCUMULO-3439 Add RegexGroupBalancer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29230/#review66915
-----------------------------------------------------------
Nit: whitespace
Nit: single-line statements w/out braces
server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
<https://reviews.apache.org/r/29230/#comment110619>
final
server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
<https://reviews.apache.org/r/29230/#comment110620>
this(null);
server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
<https://reviews.apache.org/r/29230/#comment110621>
final
server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
<https://reviews.apache.org/r/29230/#comment110622>
final
server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
<https://reviews.apache.org/r/29230/#comment110623>
final
server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
<https://reviews.apache.org/r/29230/#comment110624>
final
server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
<https://reviews.apache.org/r/29230/#comment110625>
@Override
server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
<https://reviews.apache.org/r/29230/#comment110626>
@Override
server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
<https://reviews.apache.org/r/29230/#comment110627>
@Override
server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
<https://reviews.apache.org/r/29230/#comment110628>
Could this class be made static by passing in the table ID?
- Eric Newton
On Dec. 19, 2014, 1:52 a.m., kturner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29230/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 1:52 a.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-3439
> https://issues.apache.org/jira/browse/ACCUMULO-3439
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> The patch contains a new balancer, test, and documentation.
>
>
> Diffs
> -----
>
> docs/src/main/resources/examples/README.rgbalancer PRE-CREATION
> server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java PRE-CREATION
> server/base/src/main/java/org/apache/accumulo/server/master/balancer/RegexGroupBalancer.java PRE-CREATION
> server/base/src/main/java/org/apache/accumulo/server/master/balancer/TableLoadBalancer.java 5eae890
> server/base/src/test/java/org/apache/accumulo/server/master/balancer/GroupBalancerTest.java PRE-CREATION
> test/src/test/java/org/apache/accumulo/test/functional/RegexGroupBalanceIT.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29230/diff/
>
>
> Testing
> -------
>
> The new unit test and intergeration test added in the patch run.
>
>
> Thanks,
>
> kturner
>
>
Re: Review Request 29230: ACCUMULO-3439 Add RegexGroupBalancer
Posted by ke...@deenlo.com.
> On Jan. 6, 2015, 9:41 p.m., Eric Newton wrote:
> > Nit: whitespace
> > Nit: single-line statements w/out braces
I also turned on eclipse save action to add braces for 2nd patch
- kturner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29230/#review66915
-----------------------------------------------------------
On Jan. 7, 2015, 7:52 p.m., kturner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29230/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 7:52 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-3439
> https://issues.apache.org/jira/browse/ACCUMULO-3439
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> The patch contains a new balancer, test, and documentation.
>
>
> Diffs
> -----
>
> docs/src/main/resources/examples/README.rgbalancer PRE-CREATION
> server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java PRE-CREATION
> server/base/src/main/java/org/apache/accumulo/server/master/balancer/RegexGroupBalancer.java PRE-CREATION
> server/base/src/main/java/org/apache/accumulo/server/master/balancer/TableLoadBalancer.java 5eae890
> server/base/src/test/java/org/apache/accumulo/server/master/balancer/GroupBalancerTest.java PRE-CREATION
> test/src/test/java/org/apache/accumulo/test/functional/RegexGroupBalanceIT.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29230/diff/
>
>
> Testing
> -------
>
> The new unit test and intergeration test added in the patch run.
>
>
> Thanks,
>
> kturner
>
>
Re: Review Request 29230: ACCUMULO-3439 Add RegexGroupBalancer
Posted by ke...@deenlo.com.
> On Jan. 6, 2015, 9:41 p.m., Eric Newton wrote:
> > server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java, line 674
> > <https://reviews.apache.org/r/29230/diff/1/?file=796995#file796995line674>
> >
> > Could this class be made static by passing in the table ID?
inner class also uses `context`.
- kturner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29230/#review66915
-----------------------------------------------------------
On Jan. 7, 2015, 7:52 p.m., kturner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29230/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 7:52 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-3439
> https://issues.apache.org/jira/browse/ACCUMULO-3439
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> The patch contains a new balancer, test, and documentation.
>
>
> Diffs
> -----
>
> docs/src/main/resources/examples/README.rgbalancer PRE-CREATION
> server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java PRE-CREATION
> server/base/src/main/java/org/apache/accumulo/server/master/balancer/RegexGroupBalancer.java PRE-CREATION
> server/base/src/main/java/org/apache/accumulo/server/master/balancer/TableLoadBalancer.java 5eae890
> server/base/src/test/java/org/apache/accumulo/server/master/balancer/GroupBalancerTest.java PRE-CREATION
> test/src/test/java/org/apache/accumulo/test/functional/RegexGroupBalanceIT.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29230/diff/
>
>
> Testing
> -------
>
> The new unit test and intergeration test added in the patch run.
>
>
> Thanks,
>
> kturner
>
>