You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "TyrantLucifer (via GitHub)" <gi...@apache.org> on 2023/07/24 03:07:06 UTC

[GitHub] [seatunnel] TyrantLucifer commented on a diff in pull request #5097: [Improve][Connector-v2][Jdbc] check url not null throw friendly message

TyrantLucifer commented on code in PR #5097:
URL: https://github.com/apache/seatunnel/pull/5097#discussion_r1271684571


##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/JdbcSource.java:
##########
@@ -93,6 +98,19 @@ public String getPluginName() {
 
     @Override
     public void prepare(Config pluginConfig) throws PrepareFailException {
+        CheckResult checkResult =

Review Comment:
   This logic will invoke at factory. It's a best choice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org