You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2015/09/10 07:35:08 UTC
Re: Review Request 38239: Renamed appc.{hpp|cpp} to
slave/containerizer/provisioners/appc/provisioner.{hpp|cpp}.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38239/
-----------------------------------------------------------
(Updated Sept. 9, 2015, 10:35 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Comments.
Summary (updated)
-----------------
Renamed appc.{hpp|cpp} to slave/containerizer/provisioners/appc/provisioner.{hpp|cpp}.
Repository: mesos
Description (updated)
-------
Renamed appc.{hpp|cpp} to slave/containerizer/provisioners/appc/provisioner.{hpp|cpp}.
Diffs (updated)
-----
src/Makefile.am 0a8ef6d8551cf177cb565b2a443c05e8eea5ab1c
src/slave/containerizer/provisioner.cpp 95894c0ed97388cf2830058c13804b6baf5daad4
src/slave/containerizer/provisioners/appc.hpp
src/slave/containerizer/provisioners/appc.cpp d54b6882346df7121ec63803810fab979ac0848a
Diff: https://reviews.apache.org/r/38239/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request 38239: Renamed appc.{hpp|cpp} to
slave/containerizer/provisioners/appc/provisioner.{hpp|cpp}.
Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38239/#review98418
-----------------------------------------------------------
src/Makefile.am (line 485)
<https://reviews.apache.org/r/38239/#comment154887>
Keep them sorted.
src/Makefile.am (line 766)
<https://reviews.apache.org/r/38239/#comment154888>
Ditto
- Cong Wang
On Sept. 10, 2015, 7:04 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38239/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 7:04 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed appc.{hpp|cpp} to slave/containerizer/provisioners/appc/provisioner.{hpp|cpp}.
>
>
> Diffs
> -----
>
> src/Makefile.am cea470e14ed93a46fead9da8015df676e818e4bc
> src/slave/containerizer/provisioner.cpp 95894c0ed97388cf2830058c13804b6baf5daad4
> src/slave/containerizer/provisioners/appc.hpp 68e82e31869f05a0118154e7e601f42125dc2cf6
> src/slave/containerizer/provisioners/appc.cpp d54b6882346df7121ec63803810fab979ac0848a
>
> Diff: https://reviews.apache.org/r/38239/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 38239: Renamed appc.{hpp|cpp} to
slave/containerizer/provisioners/appc/provisioner.{hpp|cpp}.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38239/#review98442
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Sept. 10, 2015, 5:42 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38239/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 5:42 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed appc.{hpp|cpp} to slave/containerizer/provisioners/appc/provisioner.{hpp|cpp}.
>
>
> Diffs
> -----
>
> src/Makefile.am cea470e14ed93a46fead9da8015df676e818e4bc
> src/slave/containerizer/provisioner.cpp 95894c0ed97388cf2830058c13804b6baf5daad4
> src/slave/containerizer/provisioners/appc.hpp 68e82e31869f05a0118154e7e601f42125dc2cf6
> src/slave/containerizer/provisioners/appc.cpp d54b6882346df7121ec63803810fab979ac0848a
>
> Diff: https://reviews.apache.org/r/38239/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 38239: Renamed appc.{hpp|cpp} to
slave/containerizer/provisioners/appc/provisioner.{hpp|cpp}.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38239/
-----------------------------------------------------------
(Updated Sept. 10, 2015, 10:42 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
Comments.
Repository: mesos
Description
-------
Renamed appc.{hpp|cpp} to slave/containerizer/provisioners/appc/provisioner.{hpp|cpp}.
Diffs (updated)
-----
src/Makefile.am cea470e14ed93a46fead9da8015df676e818e4bc
src/slave/containerizer/provisioner.cpp 95894c0ed97388cf2830058c13804b6baf5daad4
src/slave/containerizer/provisioners/appc.hpp 68e82e31869f05a0118154e7e601f42125dc2cf6
src/slave/containerizer/provisioners/appc.cpp d54b6882346df7121ec63803810fab979ac0848a
Diff: https://reviews.apache.org/r/38239/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request 38239: Renamed appc.{hpp|cpp} to
slave/containerizer/provisioners/appc/provisioner.{hpp|cpp}.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38239/
-----------------------------------------------------------
(Updated Sept. 10, 2015, 12:04 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
Rebased.
Repository: mesos
Description
-------
Renamed appc.{hpp|cpp} to slave/containerizer/provisioners/appc/provisioner.{hpp|cpp}.
Diffs (updated)
-----
src/Makefile.am cea470e14ed93a46fead9da8015df676e818e4bc
src/slave/containerizer/provisioner.cpp 95894c0ed97388cf2830058c13804b6baf5daad4
src/slave/containerizer/provisioners/appc.hpp 68e82e31869f05a0118154e7e601f42125dc2cf6
src/slave/containerizer/provisioners/appc.cpp d54b6882346df7121ec63803810fab979ac0848a
Diff: https://reviews.apache.org/r/38239/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request 38239: Renamed appc.{hpp|cpp} to
slave/containerizer/provisioners/appc/provisioner.{hpp|cpp}.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38239/
-----------------------------------------------------------
(Updated Sept. 9, 2015, 11:57 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Renamed header guard.
Repository: mesos
Description
-------
Renamed appc.{hpp|cpp} to slave/containerizer/provisioners/appc/provisioner.{hpp|cpp}.
Diffs (updated)
-----
src/Makefile.am 0a8ef6d8551cf177cb565b2a443c05e8eea5ab1c
src/slave/containerizer/provisioner.cpp 95894c0ed97388cf2830058c13804b6baf5daad4
src/slave/containerizer/provisioners/appc.hpp 68e82e31869f05a0118154e7e601f42125dc2cf6
src/slave/containerizer/provisioners/appc.cpp d54b6882346df7121ec63803810fab979ac0848a
Diff: https://reviews.apache.org/r/38239/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu