[GitHub] [hbase] wchevreuil commented on issue #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when…

[GitBox <gi...@apache.org>]

wchevreuil commented on issue #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when…
URL: https://github.com/apache/hbase/pull/740#issuecomment-553810369
 
 
   Thanks for the comment @joshelser ! Please find my remarks below:
   
   > Forgive me, but if we have hbase.rootdir and hbase.wal.dir on separate filesystems, aren't the recovered.edits on the wal filesystem? 
   If that's the case, we can't archive recovered.edits into hbase.rootdir because a simple mv will fail.
   
   Yes, here the edits are on same FS from WALs dir. The fix proposed here identifies when the WAL is on a different FS than the root dir, passing the correct path to _HFileArchiveUtil.getStoreArchivePathForRootDir_, so that it can resolve the correct FS, avoiding the situation where we try to run "cross file system" operations. The edits would be moved to an archive folder on the same WAL FS. Makes sense?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services