You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/03/13 21:09:54 UTC
[PR] Fix AttachmentMtomChunkingTest port collision with AttachmentChunkingTest [cxf]
gnodet opened a new pull request, #2972:
URL: https://github.com/apache/cxf/pull/2972
## Summary
- Both `AttachmentChunkingTest` and `AttachmentMtomChunkingTest` have inner classes named `DownloadServer`
- Both use `allocatePort(DownloadServer.class)` which resolves to the same port via `TestUtil` (stores under the simple class name `DownloadServer`)
- When both tests run in the same JVM, the second test fails with `ListenerRegistrationException: Soap 1.1 endpoint already registered on address`
- Fix: use `allocatePort(AttachmentMtomChunkingTest.class)` to get a distinct port
## Test plan
- [ ] Both `AttachmentChunkingTest` and `AttachmentMtomChunkingTest` pass in the same surefire fork
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix AttachmentMtomChunkingTest port collision with AttachmentChunkingTest [cxf]
Posted by "coheigea (via GitHub)" <gi...@apache.org>.
coheigea closed pull request #2972: Fix AttachmentMtomChunkingTest port collision with AttachmentChunkingTest
URL: https://github.com/apache/cxf/pull/2972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix AttachmentMtomChunkingTest port collision with AttachmentChunkingTest [cxf]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on PR #2972:
URL: https://github.com/apache/cxf/pull/2972#issuecomment-4103523632
Should be fixed by https://github.com/apache/cxf/pull/2973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix AttachmentMtomChunkingTest port collision with AttachmentChunkingTest [cxf]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #2972:
URL: https://github.com/apache/cxf/pull/2972#discussion_r2933853592
##########
systests/jaxws/src/test/java/org/apache/cxf/systest/jaxws/AttachmentMtomChunkingTest.java:
##########
@@ -44,7 +44,7 @@
import static org.junit.Assert.assertTrue;
public class AttachmentMtomChunkingTest extends AbstractAttachmentChunkingTest {
- private static final String PORT = allocatePort(DownloadServer.class);
+ private static final String PORT = allocatePort(AttachmentMtomChunkingTest.class);
Review Comment:
This is great finding @gnodet , however I think we would have to address the cause:
- `allocatePort()` sets two properties, with full class name, and simple class name
- the conflict is apparently over simple class name
It would be beneficial to improve `TestUtil` to catch those conflicts (it can do it, properties are static), so the test suite fails to run and would need to be fixed. Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org