[GitHub] [incubator-kyuubi] cfmcgrady commented on a diff in pull request #3918: [KYUUBI #3909][TEST] the new client should work properly when the engine exits unexpectedly

[GitBox <gi...@apache.org>]

cfmcgrady commented on code in PR #3918:
URL: https://github.com/apache/incubator-kyuubi/pull/3918#discussion_r1041788140


##########
kyuubi-server/src/test/scala/org/apache/kyuubi/operation/KyuubiOperationPerUserSuite.scala:
##########
@@ -298,7 +298,7 @@ class KyuubiOperationPerUserSuite
         // force kill engine without shutdown hook
         exitReq.setStatement("java.lang.Runtime.getRuntime().halt(-1)")
         exitReq.setSessionHandle(handle)
-        exitReq.setRunAsync(true)
+        exitReq.setRunAsync(false)

Review Comment:
   it should be false, thank you for the fix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org