[GitHub] [pinot] atris commented on a change in pull request #7684: Support FST Index using Native FST Library

[GitBox <gi...@apache.org>]

atris commented on a change in pull request #7684:
URL: https://github.com/apache/pinot/pull/7684#discussion_r742158076



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/filter/FilterOperatorUtils.java
##########
@@ -63,10 +63,10 @@ public static BaseFilterOperator getLeafFilterOperator(PredicateEvaluator predic
       }
       return new ScanBasedFilterOperator(predicateEvaluator, dataSource, numDocs);
     } else if (predicateType == Predicate.Type.REGEXP_LIKE) {
-      if (dataSource.getFSTIndex() != null && dataSource.getDataSourceMetadata().isSorted()) {
+      if (isFSTIndexPresent(dataSource) && dataSource.getDataSourceMetadata().isSorted()) {

Review comment:
       We already have a FSTIndex -- one of the key principles of this PR is to not touch the existing implementation




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org