You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by "sjcobb (via GitHub)" <gi...@apache.org> on 2023/06/03 02:16:30 UTC

[GitHub] [echarts] sjcobb commented on pull request #18607: export CallbackDataParams from util/types

sjcobb commented on PR #18607:
URL: https://github.com/apache/echarts/pull/18607#issuecomment-1574571359

   > https://github.com/apache/echarts/pull/18607/files#diff-68e24c987607b526e911e41eeefd62c918bfad7ec6d3af6e998c7b8c54e95f2eR40
   > 
   > It could be imported here.
   
   Thanks! I also completely missed that this is already exported out with the name `DefaultLabelFormatterCallbackParams` [here](https://github.com/apache/echarts/blob/5.4.2/src/export/option.ts#L286). 😣 Sorry for the noise with this PR, but I appreciate the review. 
   
   I noticed a [TODO](https://github.com/apache/echarts/blob/5.4.2/src/util/types.ts#L675
   ) above where CallbackDataParams is defined, `TODO: TYPE Different callback param for different series` that I could potentially look into in a separate PR if there is interest?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org