You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/07/30 07:28:24 UTC
[GitHub] [nifi] Fabryprog opened a new pull request #4441: NIFI 7525 - Create a nullValue() Subjectless Functions and support null type on Expression Language
Fabryprog opened a new pull request #4441:
URL: https://github.com/apache/nifi/pull/4441
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables NIFI-7525 functionality_
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] Fabryprog closed pull request #4441: NIFI 7525 - Create a nullValue() Subjectless Functions and support null type on Expression Language
Posted by GitBox <gi...@apache.org>.
Fabryprog closed pull request #4441:
URL: https://github.com/apache/nifi/pull/4441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #4441: NIFI 7525 - Create a nullValue() Subjectless Functions and support null type on Expression Language
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #4441:
URL: https://github.com/apache/nifi/pull/4441#issuecomment-826170718
We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] Fabryprog commented on pull request #4441: NIFI 7525 - Create a nullValue() Subjectless Functions and support null type on Expression Language
Posted by GitBox <gi...@apache.org>.
Fabryprog commented on pull request #4441:
URL: https://github.com/apache/nifi/pull/4441#issuecomment-683768322
> I don't see the usefulness of such a method and I am not sure it is worth the big code change, sorry
Hello Marco! Thanks for your time!
In the past I've been use NiFi for some data trasformations and, sometime, some automatical conversions (for example from JSON -> Avro) wasn't compatible with the "empty value filosofy" used inside NiFi. For example: When I have an empty value: what is it? Is it a string? is a number? It could be a "null" values?
This change skips this misunderstanding enabling the user to use programmatically NULL value (inside of expression language)
if you think it's better, I can create an article to expose that!
Kind regards
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] Fabryprog commented on pull request #4441: NIFI 7525 - Create a nullValue() Subjectless Functions and support null type on Expression Language
Posted by GitBox <gi...@apache.org>.
Fabryprog commented on pull request #4441:
URL: https://github.com/apache/nifi/pull/4441#issuecomment-666221835
Note: **ci-workflow** failed in other modules. I modified only **nifi-expression-language**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] Fabryprog edited a comment on pull request #4441: NIFI 7525 - Create a nullValue() Subjectless Functions and support null type on Expression Language
Posted by GitBox <gi...@apache.org>.
Fabryprog edited a comment on pull request #4441:
URL: https://github.com/apache/nifi/pull/4441#issuecomment-668659189
Hello friends @adarmiento @mgaido91
How to about that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mgaido91 commented on pull request #4441: NIFI 7525 - Create a nullValue() Subjectless Functions and support null type on Expression Language
Posted by GitBox <gi...@apache.org>.
mgaido91 commented on pull request #4441:
URL: https://github.com/apache/nifi/pull/4441#issuecomment-683761763
I don't see the usefulness of such a method and I am not sure it is worth the big code change, sorry
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] Fabryprog commented on pull request #4441: NIFI 7525 - Create a nullValue() Subjectless Functions and support null type on Expression Language
Posted by GitBox <gi...@apache.org>.
Fabryprog commented on pull request #4441:
URL: https://github.com/apache/nifi/pull/4441#issuecomment-668659189
Hello friend @adarmiento @mgaido91
How to about that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mgaido91 commented on pull request #4441: NIFI 7525 - Create a nullValue() Subjectless Functions and support null type on Expression Language
Posted by GitBox <gi...@apache.org>.
mgaido91 commented on pull request #4441:
URL: https://github.com/apache/nifi/pull/4441#issuecomment-683769823
I think you can maybe send an email in the community list to check whether this is a feature many people need and in case of a favorable result we can go ahead with the PR. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] adarmiento commented on pull request #4441: NIFI 7525 - Create a nullValue() Subjectless Functions and support null type on Expression Language
Posted by GitBox <gi...@apache.org>.
adarmiento commented on pull request #4441:
URL: https://github.com/apache/nifi/pull/4441#issuecomment-683779159
Hello @Fabryprog,
Whatever the outcome of the discussion with the community, I would undersline that you are not actually interested in the null value itself (if I understood correctly) but rather in propagating the type a field which is null for a specific in-transit object
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #4441: NIFI 7525 - Create a nullValue() Subjectless Functions and support null type on Expression Language
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #4441:
URL: https://github.com/apache/nifi/pull/4441#issuecomment-826170718
We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org