[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8577: boards/samv7/hsmci: add option to invert card detection pin

["pkarashchenko (via GitHub)" <gi...@apache.org>]

pkarashchenko commented on code in PR #8577:
URL: https://github.com/apache/nuttx/pull/8577#discussion_r1111331559


##########
boards/arm/samv7/common/include/board_hsmci.h:
##########
@@ -59,7 +59,7 @@ extern "C"
  ****************************************************************************/
 
 int sam_hsmci_initialize(int slotno, int minor, gpio_pinset_t cdcfg,
-                         int cdirq);
+                         int cdirq, bool cdinvert);

Review Comment:
   I'm just wondering of this solution as adding define `BOARD_HSMCI_CD_STATE` to `board.h` seems to me a chipper solution.
   @Cynerd do you have any objections if I will rework the code and remove parameter + new data in favour of CD "inserted" level define in `board.h`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org