You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/27 17:18:15 UTC
[GitHub] [shardingsphere] ntsompa opened a new pull request #16420: Add assertGetTableMetaDataPath() for unit testing #16386
ntsompa opened a new pull request #16420:
URL: https://github.com/apache/shardingsphere/pull/16420
Fixes #16386.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #16420: Add assertGetTableMetaDataPath() for unit testing #16386
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #16420:
URL: https://github.com/apache/shardingsphere/pull/16420#issuecomment-1080018767
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16420?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16420](https://codecov.io/gh/apache/shardingsphere/pull/16420?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0638f79) into [master](https://codecov.io/gh/apache/shardingsphere/commit/dec71051a276e34ba8391346c7eacb31a9022385?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dec7105) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #16420 +/- ##
=========================================
Coverage 60.77% 60.77%
Complexity 2089 2089
=========================================
Files 3319 3319
Lines 50176 50176
Branches 8598 8598
=========================================
Hits 30494 30494
Misses 17137 17137
Partials 2545 2545
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16420?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16420?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dec7105...0638f79](https://codecov.io/gh/apache/shardingsphere/pull/16420?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb commented on pull request #16420: Add assertGetTableMetaDataPath() for unit testing #16386
Posted by GitBox <gi...@apache.org>.
zjcnb commented on pull request #16420:
URL: https://github.com/apache/shardingsphere/pull/16420#issuecomment-1080111970
It has conflicts, Resolve it please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb removed a comment on pull request #16420: Add assertGetTableMetaDataPath() for unit testing #16386
Posted by GitBox <gi...@apache.org>.
zjcnb removed a comment on pull request #16420:
URL: https://github.com/apache/shardingsphere/pull/16420#issuecomment-1080111970
It has conflicts, Resolve it please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb merged pull request #16420: Add assertGetTableMetaDataPath() for unit testing #16386
Posted by GitBox <gi...@apache.org>.
zjcnb merged pull request #16420:
URL: https://github.com/apache/shardingsphere/pull/16420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb commented on pull request #16420: Add assertGetTableMetaDataPath() for unit testing #16386
Posted by GitBox <gi...@apache.org>.
zjcnb commented on pull request #16420:
URL: https://github.com/apache/shardingsphere/pull/16420#issuecomment-1080111762
It has conflicts, Resolve it please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #16420: Add assertGetTableMetaDataPath() for unit testing #16386
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #16420:
URL: https://github.com/apache/shardingsphere/pull/16420#issuecomment-1080018767
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16420?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16420](https://codecov.io/gh/apache/shardingsphere/pull/16420?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d869caf) into [master](https://codecov.io/gh/apache/shardingsphere/commit/d20ea36042f011b1e1c7a8d2917436f86f2a4b8d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d20ea36) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #16420 +/- ##
=========================================
Coverage 60.73% 60.73%
Complexity 2091 2091
=========================================
Files 3324 3324
Lines 50223 50223
Branches 8603 8603
=========================================
Hits 30503 30503
Misses 17174 17174
Partials 2546 2546
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16420?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16420?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d20ea36...d869caf](https://codecov.io/gh/apache/shardingsphere/pull/16420?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org