You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by po...@apache.org on 2022/09/08 19:06:58 UTC

[airflow] 01/03: Fix case when SHELL variable is not set in kubernetes tests (#26235)

This is an automated email from the ASF dual-hosted git repository.

potiuk pushed a commit to branch v2-4-test
in repository https://gitbox.apache.org/repos/asf/airflow.git

commit 7f6e0d7728f370aff3a17d104dd656502ed19581
Author: Jarek Potiuk <ja...@polidea.com>
AuthorDate: Thu Sep 8 15:47:32 2022 +0200

    Fix case when SHELL variable is not set in kubernetes tests (#26235)
    
    When SHELL variable is not set, kubernetes tests will fall back
    to using 'bash'
    
    (cherry picked from commit b7db311336bbe909ee7f559af2b1da7635c54823)
---
 dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py b/dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py
index 488be2548b..7857260e08 100644
--- a/dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py
+++ b/dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py
@@ -1332,7 +1332,7 @@ def _run_tests(
     env = get_k8s_env(python=python, kubernetes_version=kubernetes_version, executor=executor)
     kubectl_cluster_name = get_kubectl_cluster_name(python=python, kubernetes_version=kubernetes_version)
     get_console(output=output).print(f"\n[info]Running tests with {kubectl_cluster_name} cluster.")
-    shell_binary = env['SHELL']
+    shell_binary = env.get('SHELL', shutil.which('bash'))
     extra_shell_args: List[str] = []
     if shell_binary.endswith("zsh"):
         extra_shell_args.append('--no-rcs')