You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by ha...@apache.org on 2023/01/09 14:19:51 UTC

[hop] branch master updated: 2110 - Unexpected error evaluation condition on Filter Rows transform 2136 - Filter String comparisons using the = operator do not work, while using IN LIST will. 2135 - Filter - Fails comparing Boolean using = against Boolean with a True value.

This is an automated email from the ASF dual-hosted git repository.

hansva pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hop.git


The following commit(s) were added to refs/heads/master by this push:
     new 07a8fedfa4 2110 - Unexpected error evaluation condition on Filter Rows transform 2136 - Filter String comparisons using the = operator do not work, while using IN LIST will. 2135 - Filter - Fails comparing Boolean using = against Boolean with a True value.
     new eabe67d527 Merge pull request #2138 from sramazzina/2110
07a8fedfa4 is described below

commit 07a8fedfa419cabe0d52173e8edcc63e16b04fe8
Author: sramazzina <se...@serasoft.it>
AuthorDate: Mon Jan 9 12:42:58 2023 +0100

    2110 - Unexpected error evaluation condition on Filter Rows transform
    2136 - Filter String comparisons using the = operator do not work, while using IN LIST will.
    2135 - Filter - Fails comparing Boolean using = against Boolean with a True value.
---
 core/src/main/java/org/apache/hop/core/Condition.java | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/core/src/main/java/org/apache/hop/core/Condition.java b/core/src/main/java/org/apache/hop/core/Condition.java
index 9dccffbca8..7de539c64c 100644
--- a/core/src/main/java/org/apache/hop/core/Condition.java
+++ b/core/src/main/java/org/apache/hop/core/Condition.java
@@ -17,12 +17,6 @@
 
 package org.apache.hop.core;
 
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.regex.Pattern;
 import org.apache.commons.lang.StringUtils;
 import org.apache.hop.core.exception.HopException;
 import org.apache.hop.core.exception.HopPluginException;
@@ -41,10 +35,10 @@ import org.apache.hop.metadata.api.IEnumHasCodeAndDescription;
 import org.apache.hop.metadata.serializer.xml.XmlMetadataUtil;
 import org.w3c.dom.Node;
 
-import static org.apache.hop.core.Condition.Function.EQUAL;
-import static org.apache.hop.core.Condition.Function.NOT_NULL;
-import static org.apache.hop.core.Condition.Function.NULL;
-import static org.apache.hop.core.Condition.Function.TRUE;
+import java.util.*;
+import java.util.regex.Pattern;
+
+import static org.apache.hop.core.Condition.Function.*;
 import static org.apache.hop.core.Condition.Operator.AND;
 import static org.apache.hop.core.Condition.Operator.NONE;
 
@@ -163,6 +157,7 @@ public class Condition implements Cloneable {
     this.operator = NONE;
     this.negated = false;
     this.rightValue = null;
+    this.function = EQUAL;
 
     leftFieldIndex = -2;
     rightFieldIndex = -2;