[GitHub] [myfaces] melloware commented on a diff in pull request #529: MYFACES-4589: Quarkus classes registered for reflection

["melloware (via GitHub)" <gi...@apache.org>]

melloware commented on code in PR #529:
URL: https://github.com/apache/myfaces/pull/529#discussion_r1113011444


##########
extensions/quarkus/deployment/src/main/java/org/apache/myfaces/core/extensions/quarkus/deployment/MyFacesProcessor.java:
##########
@@ -462,6 +464,25 @@ void registerForMethodReflection(MyFacesRecorder recorder, BuildProducer<Reflect
         List<Class<?>> classes = new ArrayList<>();
 
         classNames.add("jakarta.faces._FactoryFinderProviderFactory");
+        classNames.add("java.util.Set");

Review Comment:
   Yep will fix I migrated these fixes from OmniFaces Extension and realized it didn't belong there but I will upate!



##########
extensions/quarkus/deployment/src/main/java/org/apache/myfaces/core/extensions/quarkus/deployment/MyFacesProcessor.java:
##########
@@ -462,6 +464,25 @@ void registerForMethodReflection(MyFacesRecorder recorder, BuildProducer<Reflect
         List<Class<?>> classes = new ArrayList<>();
 
         classNames.add("jakarta.faces._FactoryFinderProviderFactory");
+        classNames.add("java.util.Set");

Review Comment:
   Yep will fix I migrated these fixes from OmniFaces Extension and realized it didn't belong there but I will update!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org