You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2016/09/10 00:39:21 UTC
[jira] [Commented] (YARN-3140) Improve locks in AbstractCSQueue/LeafQueue/ParentQueue

    [ https://issues.apache.org/jira/browse/YARN-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478793#comment-15478793 ] 

Hadoop QA commented on YARN-3140:
---------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 20s {color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s {color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 25s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 22s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 37s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 18s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 57s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 34s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 30s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 19s {color} | {color:red} hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 40 new + 82 unchanged - 57 fixed = 122 total (was 139) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 34s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 3s {color} | {color:red} hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 24m 17s {color} | {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s {color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 39m 48s {color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager |
|  |  Unread field:LeafQueue.java:[line 1824] |
|  |  Increment of volatile field org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue$User.activeApplications in org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue$User.activateApplication()  At LeafQueue.java:in org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue$User.activateApplication()  At LeafQueue.java:[line 1905] |
|  |  Increment of volatile field org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue$User.pendingApplications in org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue$User.activateApplication()  At LeafQueue.java:in org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue$User.activateApplication()  At LeafQueue.java:[line 1904] |
|  |  Increment of volatile field org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue$User.activeApplications in org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue$User.finishApplication(boolean)  At LeafQueue.java:in org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue$User.finishApplication(boolean)  At LeafQueue.java:[line 1915] |
|  |  Increment of volatile field org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue$User.pendingApplications in org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue$User.finishApplication(boolean)  At LeafQueue.java:in org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue$User.finishApplication(boolean)  At LeafQueue.java:[line 1917] |
|  |  Increment of volatile field org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue$User.pendingApplications in org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue$User.submitApplication()  At LeafQueue.java:in org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue$User.submitApplication()  At LeafQueue.java:[line 1895] |
| Failed junit tests | hadoop.yarn.server.resourcemanager.scheduler.capacity.TestParentQueue |
|   | hadoop.yarn.server.resourcemanager.reservation.TestCapacitySchedulerPlanFollower |
|   | hadoop.yarn.server.resourcemanager.scheduler.TestSchedulerHealth |
|   | hadoop.yarn.server.resourcemanager.TestResourceManager |
|   | hadoop.yarn.server.resourcemanager.scheduler.capacity.TestChildQueueOrder |
|   | hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue |
|   | hadoop.yarn.server.resourcemanager.scheduler.capacity.TestApplicationLimits |
| Timed out junit tests | org.apache.hadoop.yarn.server.resourcemanager.TestApplicationCleanup |
|   | org.apache.hadoop.yarn.server.resourcemanager.ahs.TestRMApplicationHistoryWriter |
|   | org.apache.hadoop.yarn.server.resourcemanager.TestSignalContainer |
|   | org.apache.hadoop.yarn.server.resourcemanager.rmcontainer.TestRMContainerImpl |
|   | org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart |
|   | org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler |
|   | org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestApplicationPriority |
|   | org.apache.hadoop.yarn.server.resourcemanager.scheduler.TestAbstractYarnScheduler |
|   | org.apache.hadoop.yarn.server.resourcemanager.TestRM |
|   | org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched |
|   | org.apache.hadoop.yarn.server.resourcemanager.TestRMHA |
|   | org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation |
|   | org.apache.hadoop.yarn.server.resourcemanager.TestNodeBlacklistingOnAMFailures |
|   | org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRMRPCResponseId |
|   | org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerResizing |
|   | org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerDynamicBehavior |
|   | org.apache.hadoop.yarn.server.resourcemanager.scheduler.TestSchedulingWithAllocationRequestId |
|   | org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestApplicationLimitsByPartition |
|   | org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerSurgicalPreemption |
|   | org.apache.hadoop.yarn.server.resourcemanager.scheduler.TestSchedulerUtils |
|   | org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation |
|   | org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification |
|   | org.apache.hadoop.yarn.server.resourcemanager.TestApplicationMasterService |
|   | org.apache.hadoop.yarn.server.resourcemanager.TestApplicationACLs |
|   | org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerLazyPreemption |
|   | org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService |
|   | org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestWorkPreservingRMRestartForNodeLabel |
|   | org.apache.hadoop.yarn.server.resourcemanager.TestApplicationMasterLauncher |
|   | org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService |
|   | org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesSchedulerActivities |
|   | org.apache.hadoop.yarn.server.resourcemanager.TestDecommissioningNodesWatcher |
|   | org.apache.hadoop.yarn.server.resourcemanager.TestContainerResourceUsage |
|   | org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA |
|   | org.apache.hadoop.yarn.server.resourcemanager.TestAMAuthorization |
|   | org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRMRPCNodeUpdates |
|   | org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA |
|   | org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer |
|   | org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart |
|   | org.apache.hadoop.yarn.server.resourcemanager.scheduler.policy.TestFairOrderingPolicy |
|   | org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerQueueACLs |
|   | org.apache.hadoop.yarn.server.resourcemanager.security.TestClientToAMTokens |
|   | org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerNodeLabelUpdate |
|   | org.apache.hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart |
|   | org.apache.hadoop.yarn.server.resourcemanager.rmapp.TestNodesListManager |
|   | org.apache.hadoop.yarn.server.resourcemanager.security.TestAMRMTokens |
|   | org.apache.hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:9560f25 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12827863/YARN-3140.1.patch |
| JIRA Issue | YARN-3140 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  findbugs  checkstyle  |
| uname | Linux ae6e556c84bd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / bee9f57 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/13067/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt |
| findbugs | https://builds.apache.org/job/PreCommit-YARN-Build/13067/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html |
| unit | https://builds.apache.org/job/PreCommit-YARN-Build/13067/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt |
| unit test logs |  https://builds.apache.org/job/PreCommit-YARN-Build/13067/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt |
|  Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/13067/testReport/ |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/13067/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Improve locks in AbstractCSQueue/LeafQueue/ParentQueue
> ------------------------------------------------------
>
>                 Key: YARN-3140
>                 URL: https://issues.apache.org/jira/browse/YARN-3140
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager, scheduler
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-3140.1.patch
>
>
> Enhance locks in AbstractCSQueue/LeafQueue/ParentQueue, as mentioned in YARN-3091, a possible solution is using read/write lock. Other fine-graind locks for specific purposes / bugs should be addressed in separated tickets.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org