You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/02 10:15:00 UTC
[jira] [Commented] (KAFKA-7237) Add explicit fatal marker to fatal
error messages
[ https://issues.apache.org/jira/browse/KAFKA-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566578#comment-16566578 ]
ASF GitHub Bot commented on KAFKA-7237:
---------------------------------------
stanislavkozlovski opened a new pull request #5447: KAFKA-7237: Add explicit FATAL marker to log messages
URL: https://github.com/apache/kafka/pull/5447
https://issues.apache.org/jira/browse/KAFKA-7237
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Add explicit fatal marker to fatal error messages
> -------------------------------------------------
>
> Key: KAFKA-7237
> URL: https://issues.apache.org/jira/browse/KAFKA-7237
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Rajini Sivaram
> Assignee: Stanislav Kozlovski
> Priority: Minor
>
> We currently use FATAL markers for fatal error messages in core. But only logback supports markers out-of-the-box and log4j simply logs these as ERROR messages, ignoring the marker. We should perhaps include a String marker within these messages to make it easier to identify fatal messages in logs.
> From https://www.slf4j.org/faq.html:
> {quote}
> While markers are part of the SLF4J API, only logback supports markers off the shelf. For example, if you add the {{%marker}}conversion word to its pattern, logback's {{PatternLayout}} will add marker data to its output. Marker data can be used to [filter messages|http://logback.qos.ch/manual/filters.html] or even [trigger|http://logback.qos.ch/manual/appenders.html#OnMarkerEvaluator] an outgoing email [at the end of an individual transaction|http://logback.qos.ch/recipes/emailPerTransaction.html].
> In combination with logging frameworks such as log4j and java.util.logging which do not support markers, marker data will be silently ignored.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)