[GitHub] rogercloud commented on a change in pull request #135: KYLIN-3347 : calcite function QueryService Exception

[GitBox <gi...@apache.org>]

rogercloud commented on a change in pull request #135: KYLIN-3347 : calcite function QueryService Exception
URL: https://github.com/apache/kylin/pull/135#discussion_r184256367
 
 

 ##########
 File path: query/src/main/java/org/apache/kylin/query/util/DefaultQueryTransformer.java
 ##########
 @@ -50,6 +50,8 @@
     private static final Pattern PIN_SUM_OF_FN_CONVERT = Pattern
             .compile(S0 + "SUM" + S0 + "\\(" + S0 + "\\{\\s*fn" + SM + "convert" + S0 + "\\(" + S0 + "([^\\s,]+)" + S0
                     + "," + S0 + "SQL_DOUBLE" + S0 + "\\)" + S0 + "\\}" + S0 + "\\)", Pattern.CASE_INSENSITIVE);
+    private static final Pattern PTN_HAVING_FUNCTION = Pattern.compile("\\{fn" + "(.*?)" + "\\}",
 
 Review comment:
   It's too general as it matches all functions. How about adding a CURRENT_TIMESTAMP function like PTN_MIN_1 instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services