You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/04/02 22:49:26 UTC
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2945:
[GOBBLIN-1105] some refactoring and make MysqlJobStatusStateStore
implements DatasetStateStore
codecov-io edited a comment on issue #2945: [GOBBLIN-1105] some refactoring and make MysqlJobStatusStateStore implements DatasetStateStore
URL: https://github.com/apache/incubator-gobblin/pull/2945#issuecomment-606889224
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=h1) Report
> Merging [#2945](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/d54e66b857a34e871fd7c9ab28e37c9c9f061432&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `1.63%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc)](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2945 +/- ##
============================================
- Coverage 45.58% 45.54% -0.05%
+ Complexity 9157 9155 -2
============================================
Files 1936 1938 +2
Lines 73286 73323 +37
Branches 8088 8091 +3
============================================
- Hits 33409 33393 -16
- Misses 36782 36835 +53
Partials 3095 3095
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/gobblin/cluster/HelixJobsMapping.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhKb2JzTWFwcGluZy5qYXZh) | `89.58% <0.00%> (+6.89%)` | `13.00 <0.00> (ø)` | |
| [...rg/apache/gobblin/metastore/DatasetStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0RhdGFzZXRTdGF0ZVN0b3JlLmphdmE=) | `4.34% <ø> (+4.34%)` | `1.00 <0.00> (+1.00)` | |
| [.../apache/gobblin/metastore/DatasetStoreDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0RhdGFzZXRTdG9yZURhdGFzZXQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...metastore/FileContextBasedFsStateStoreFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0ZpbGVDb250ZXh0QmFzZWRGc1N0YXRlU3RvcmVGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ava/org/apache/gobblin/metastore/FsStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0ZzU3RhdGVTdG9yZS5qYXZh) | `32.91% <0.00%> (-3.14%)` | `14.00 <0.00> (ø)` | |
| [...he/gobblin/metastore/MysqlJobStatusStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsSm9iU3RhdHVzU3RhdGVTdG9yZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...etastore/MysqlJobStatusStateStoreEntryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsSm9iU3RhdHVzU3RhdGVTdG9yZUVudHJ5TWFuYWdlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lin/metastore/MysqlJobStatusStateStoreFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsSm9iU3RhdHVzU3RhdGVTdG9yZUZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../org/apache/gobblin/metastore/MysqlStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsU3RhdGVTdG9yZS5qYXZh) | `8.19% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...gobblin/metastore/MysqlStateStoreEntryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsU3RhdGVTdG9yZUVudHJ5TWFuYWdlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [16 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=footer). Last update [d54e66b...9689853](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services