You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/04 03:48:06 UTC
[GitHub] [hudi] rmahindra123 commented on a change in pull request #4741: [MINOR] Add configuration to enable/disable common prefix for all met…
rmahindra123 commented on a change in pull request #4741:
URL: https://github.com/apache/hudi/pull/4741#discussion_r799142506
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -1561,6 +1561,10 @@ public boolean isExecutorMetricsEnabled() {
getStringOrDefault(HoodieMetricsConfig.EXECUTOR_METRICS_ENABLE, "false"));
}
+ public boolean isMetricsCommonPrefixEnabled() {
Review comment:
Why do you need another config. Check this PR: https://github.com/apache/hudi/pull/4274/files. If you want remove the infer function for METRICS_REPORTER_PREFIX, so it does not use the table name as default and the user can set a prefix using METRICS_REPORTER_PREFIX. Does it make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org