[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8113: check cron schedules from table configs after subscribing child changes

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #8113:
URL: https://github.com/apache/pinot/pull/8113#discussion_r799844135



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java
##########
@@ -139,6 +129,46 @@ public PinotTaskManager(PinotHelixTaskResourceManager helixTaskResourceManager,
     }
   }
 
+  private class ZkTableConfigChangeListener implements IZkChildListener {
+
+    @Override
+    public synchronized void handleChildChange(String path, List<String> tableNamesWithType) {
+      checkTableConfigChanges(tableNamesWithType);
+    }
+  }
+
+  private void checkTableConfigChanges(List<String> allTableNamesWithType) {
+    LOGGER.info("Checking task config changes of tables: {}", allTableNamesWithType);

Review comment:
       This might flood the log (think of a cluster with thousands of tables. Suggest only logging the newly subscribed ones and the ones to be cleaned up




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org