You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "QuenKar (via GitHub)" <gi...@apache.org> on 2023/05/09 03:11:20 UTC
[GitHub] [arrow-datafusion] QuenKar opened a new pull request, #6292: Refactor Expr::Exists to a struct.
QuenKar opened a new pull request, #6292:
URL: https://github.com/apache/arrow-datafusion/pull/6292
# Which issue does this PR close?
Related to https://github.com/apache/arrow-datafusion/issues/2175.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
Refactor Expr::Exists to a struct.
# Are these changes tested?
Yes.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] QuenKar commented on pull request #6292: Refactor Expr::Exists to a struct.
Posted by "QuenKar (via GitHub)" <gi...@apache.org>.
QuenKar commented on PR #6292:
URL: https://github.com/apache/arrow-datafusion/pull/6292#issuecomment-1539329840
When I run `cargo test`, I met a question.
```
thread 'tpcds_logical_q64' has overflowed its stack
fatal runtime error: stack overflow
error: test failed, to rerun pass `-p datafusion --test tpcds_planning`
```
I found that this test used a lot of tables, Is this because the memory is not large enough?
my memory is 16g.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] QuenKar commented on pull request #6292: refactor: Expr::Exists to use a struct.
Posted by "QuenKar (via GitHub)" <gi...@apache.org>.
QuenKar commented on PR #6292:
URL: https://github.com/apache/arrow-datafusion/pull/6292#issuecomment-1539658140
> I have resolved conflicts. Thanks @QuenKar 's contribution. LGTM
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener merged pull request #6292: refactor: Expr::Exists to use a struct.
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener merged PR #6292:
URL: https://github.com/apache/arrow-datafusion/pull/6292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on pull request #6292: Refactor Expr::Exists to a struct.
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #6292:
URL: https://github.com/apache/arrow-datafusion/pull/6292#issuecomment-1539452233
> When I run `cargo test`, I met a question.
>
> ```
> thread 'tpcds_logical_q64' has overflowed its stack
> fatal runtime error: stack overflow
> error: test failed, to rerun pass `-p datafusion --test tpcds_planning`
> ```
>
> I found that this test used a lot of tables, and it says that stack overflow. How can I pass this test?
You can ignore it, it's a known issue #6277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on pull request #6292: refactor: Expr::Exists to use a struct.
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #6292:
URL: https://github.com/apache/arrow-datafusion/pull/6292#issuecomment-1539587688
Nice job, Thank you @QuenKar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org