You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/04/23 10:02:05 UTC

[GitHub] [iceberg] szehon-ho commented on pull request #2499: Spark: Add builder pattern to SparkAppenderFactory to handle increasing number of arguments

szehon-ho commented on pull request #2499:
URL: https://github.com/apache/iceberg/pull/2499#issuecomment-825548700


   Hi Russell, yea its just a code cleanup.
   
   Both the aforementioned PR's (#2362 and #2240) noticed there's 4 versions of the SparkAppenderFactory  Constructor and that it becomes harder and harder to add new things, and can be cleaner like this.
   
   I noticed that I added an extraneous sort-order pointer as part of copy and paste from my PR (#2240), and removed it as its now redundant with the table added by the #2362, updated the PR with the small fix 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org