[jira] [Commented] (CALCITE-2326) Generalize p(x) IS TRUE/FALSE/UNKNOWN handling in RexSimplify

["Zoltan Haindrich (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633979#comment-16633979 ] 

Zoltan Haindrich commented on CALCITE-2326:
-------------------------------------------

Passing unkownAs in the methods makes them a bit more complex - but it could ensure that the child simplification will happen in the right mode; which is I think will help.

I think that the more specific simplify method which can be directed how to handle unknown values should be changed to be "internal-only public api" or something like that.
Users then could wrap the expression into an {{f\(x\) IS TRUE}} - and use the single argument simplify() method; which is I think the best way of communicating the desired unknownAs mode.

Note: it seems to me that simplifyNot is probably making some unneccessary simplify() calls on every operanad - then calls it on the whole expressions...the last call should be enough.
https://github.com/apache/calcite/compare/master...julianhyde:2326-simplify-unknown-as?expand=1#diff-5f0afa01652e21f36d8d4172f9af4dfeL403
although it was there before...should I file a separate jira for that?


> Generalize p(x) IS TRUE/FALSE/UNKNOWN handling in RexSimplify
> -------------------------------------------------------------
>
>                 Key: CALCITE-2326
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2326
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Major
>
> Currently only IS TRUE is handle by the unknownAsFalse field variable.
> The main goal would be to extend the logic to also handle IS FALSE cases (and possibly IS UNKNOWN too)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)