You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sidneymau (via GitHub)" <gi...@apache.org> on 2024/09/19 04:47:08 UTC

[PR] GH-44168: [Python][Acero] Provide method to perform aggregations with acero for datasets [arrow]

sidneymau opened a new pull request, #44169:
URL: https://github.com/apache/arrow/pull/44169

   ### Rationale for this change
   
   See #44168 – implement an `aggregate` method for `Dataset` to facilitate out of core aggregations of arbitrary datasets using Acero.
   
   ### What changes are included in this PR?
   
   New `aggregate` method of `Dataset` and associated tests.
   
   ### Are these changes tested?
   
   Equivalent tests to those existing for the `group_by`/`aggregate` idiom of `Table` have been added to the dataset tests.
   
   ### Are there any user-facing changes?
   
   New method of `Dataset`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44168: [Python][Acero] Provide method to perform aggregations with acero for datasets [arrow]

Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #44169:
URL: https://github.com/apache/arrow/pull/44169#issuecomment-3378224456

   This looks pretty good as a starting point for a PR. That said adding an `dataset.aggregate` seems like a significant API change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44168: [Python][Acero] Provide method to perform aggregations with acero for datasets [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44169:
URL: https://github.com/apache/arrow/pull/44169#issuecomment-6058802218

   Thank you for your contribution. Unfortunately, this pull request has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this PR will be closed in 14 days.  Feel free to re-open this if it has been closed in error. If you do not have repository permissions to reopen the PR, please tag a maintainer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44168: [Python][Acero] Provide method to perform aggregations with acero for datasets [arrow]

Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #44169:
URL: https://github.com/apache/arrow/pull/44169#issuecomment-3374426768

   @sidneymau do ping when it's ready for review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44168: [Python][Acero] Provide method to perform aggregations with acero for datasets [arrow]

Posted by "sidneymau (via GitHub)" <gi...@apache.org>.
sidneymau commented on PR #44169:
URL: https://github.com/apache/arrow/pull/44169#issuecomment-3374438388

   Will do! I actually expect the code itself is more or less ready to be reviewed, but I haven't had the time to go through the contributing guidelines carefully enough to understand how feature requests should properly be made, etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44168: [Python][Acero] Provide method to perform aggregations with acero for datasets [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #44169: GH-44168: [Python][Acero] Provide method to perform aggregations with acero for datasets
URL: https://github.com/apache/arrow/pull/44169


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44168: [Python][Acero] Provide method to perform aggregations with acero for datasets [arrow]

Posted by "sidneymau (via GitHub)" <gi...@apache.org>.
sidneymau commented on PR #44169:
URL: https://github.com/apache/arrow/pull/44169#issuecomment-3374189429

   Sorry, didn't realize that a commit would trigger a review request. Let me change this to a draft


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44168: [Python][Acero] Provide method to perform aggregations with acero for datasets [arrow]

Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #44169:
URL: https://github.com/apache/arrow/pull/44169#issuecomment-6363947948

   @sidneymau feel free to reopen if you feel this still makes sense!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44168: [Python][Acero] Provide method to perform aggregations with acero for datasets [arrow]

Posted by "sidneymau (via GitHub)" <gi...@apache.org>.
sidneymau commented on PR #44169:
URL: https://github.com/apache/arrow/pull/44169#issuecomment-3378297010

   Yes, it would be a non-trivial change to the `Dataset` class, but in principle it is in line with the other methods already implemented (e.g., `join`) and leverages the same code used by `Table`. As I haven't contributed to arrow before, I'd love to properly propose this and chat with the developers before having anyone look at this seriously, but I haven't had the time to initiate any discussion. I was thinking an upcoming pyarrow dev meeting may be an appropriate venue, otherwise I am happy to start a thread on the `dev@` mailing list


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44168: [Python][Acero] Provide method to perform aggregations with acero for datasets [arrow]

Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #44169:
URL: https://github.com/apache/arrow/pull/44169#issuecomment-3378325372

   Pyarrow dev meeting is a good venue for this discussion, another is here or on your issue (sorry, we didn't engage on https://github.com/apache/arrow/issues/44168). I am not best equipped to comment on Python API design, perhaps  @AlenkaF or @raulcd can comment once the release work winds down.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44168: [Python][Acero] Provide method to perform aggregations with acero for datasets [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44169:
URL: https://github.com/apache/arrow/pull/44169#issuecomment-2359969690

   :warning: GitHub issue #44168 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org