You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mladen Turk <mt...@apache.org> on 2012/03/20 09:49:24 UTC
[VOTE] Release Apache Tomcat Connectors 1.2.34
Hi,
Apache Tomcat Connectors 1.2.34 release candidate is ready
for vote at [1]. This version solves regression(s) found in
released version 1.2.33 and one long lasting IIS shared memory
synchronization bug.
The VOTE will remain open for at least 48 hours.
The Apache Tomcat Connectors 1.2.34 is
[ ] Stable, go ahead and release
[ ] Broken because of ...
[1] http://people.apache.org/~mturk/tomcat-connectors/jk-1.2.34/
Regards
--
^TM
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Connectors 1.2.34
Posted by Mladen Turk <mt...@apache.org>.
On 03/22/2012 11:43 AM, Rainer Jung wrote:
> On 20.03.2012 09:49, Mladen Turk wrote:
>> Hi,
>
> +0.
>
> Observed problem: due to a typo in the config file (wrong name of jk status worker in a JkMount) the web server crashed during startup.
>
The fix was trivial.
IMHO the entire extension_uri code is pretty unsafe.
I tried to add few more checks and actually stop processing
in case of error (looks like someone coded that in a hurry :)
Regards
--
^TM
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Connectors 1.2.34
Posted by Mladen Turk <mt...@apache.org>.
On 03/22/2012 11:43 AM, Rainer Jung wrote:
> On 20.03.2012 09:49, Mladen Turk wrote:
>> Hi,
>
> - strange JK_REVISION, just "()". When I run the release script, the real svn revision is put into the variable. The value goes into the full exposed version. It was only introduced a few versions ago and the missing svn revision is not a real problem (as
> long as we don't reuse the tag).
>
Remove that completely.
I wasn't aware that jkrelease.sh actually modifies jk_version.sh
We must have the same files as inside TAG, so if needed this hast to be
done before TAG. Also from users PoV, that's useless info. We have release version and that's it.
> - build.properties.autoconf, native/build.xml and the jkant directory
> missing from dist. Not sure whether those still would do anything
> useful. Not a regression.
>
Suppose we can remove those altogether.
Regards
--
^TM
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Connectors 1.2.34
Posted by Rainer Jung <ra...@kippdata.de>.
On 20.03.2012 09:49, Mladen Turk wrote:
> Hi,
>
> Apache Tomcat Connectors 1.2.34 release candidate is ready
> for vote at [1]. This version solves regression(s) found in
> released version 1.2.33 and one long lasting IIS shared memory
> synchronization bug.
>
> The VOTE will remain open for at least 48 hours.
>
> The Apache Tomcat Connectors 1.2.34 is
> [ ] Stable, go ahead and release
> [ ] Broken because of ...
+0.
Observed problem: due to a typo in the config file (wrong name of jk
status worker in a JkMount) the web server crashed during startup.
Error log and possible not starting at all would be acceptable, crashing
is not nice. If we were still at 1.2.32 I would be -1, but since 1.2.33
is out there and *really* broken, I'd say I'm neutral on whether this is
acceptable.
Stack:
fe2764e4 extension_fix (1ddc00, 1dde30, 1ddde8, 1dc330, 6000, 6058) + 50
fe278354 uri_worker_map_ext (1ddc00, 1dc330, d25, fe29e120, 2,
fe29e028) + d0
fe261db0 jk_post_config (8a868, 90310, 113eb0, 90310, 1d2e9b, 0) + 728
0003c90c ap_run_post_config (8a868, b8920, ba928, 90310, 1c4f70, 0) + 60
000296ac main (888f0, 8a868, 7f000, 0, ffbffb44, ffbffb54) + 62c
00028ba8 _start (0, 0, 0, 0, 0, 0) + 5c
I could post details later, but I think they are not necessary for
imminent release decision.
Other stuff:
- strange JK_REVISION, just "()". When I run the release script, the
real svn revision is put into the variable. The value goes into the full
exposed version. It was only introduced a few versions ago and the
missing svn revision is not a real problem (as long as we don't reuse
the tag).
Details:
- Sigs and hashes OK
- key in KEYS file
- gz and zip for src identical
- src consistent with svn tag, except for the following minor points
(no regression or fixed now)
- LICENSE and NOTICE moved one directory up (OK)
- KEYS not in dist (OK)
- deprectated jk2 xdocs missing in dist (OK)
- additional generated files in dist: aclocal.m4, configure,
Makefile.in, config.h.in, html docs in docs (OK)
- additional auto tool copied files in dist: install-sh, ltmain.sh,
missing (OK)
- build.properties.autoconf, native/build.xml and the jkant directory
missing from dist. Not sure whether those still would do anything
useful. Not a regression.
Builds succesfully on
- Solaris 8 Sparc as 32 Bit Binaries against 2.2
- Tool chain:
- platform gcc except for Solaris
(gcc 4.1.2 for Solaris 8)
- CFLAGS: -O2 -g -Wall -fno-strict-aliasing
(and -mpcu=v9 on Solaris)
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[WITHDRAWN] Was: [VOTE] Release Apache Tomcat Connectors 1.2.34
Posted by Mladen Turk <mt...@apache.org>.
>
> [1] http://people.apache.org/~mturk/tomcat-connectors/jk-1.2.34/
>
Withdrawn because of crash in case of config typo.
That's not acceptable.
Will tag 1.2.35 later today.
Regards
--
^TM
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Connectors 1.2.34
Posted by Tim Whittington <ti...@apache.org>.
The Apache Tomcat Connectors 1.2.34 is
[X] Stable, go ahead and release
[ ] Broken because of ...
Looks fine on a quick test on OS X Snow Leopard, Windows 2003 Server.
I'm off on holiday, so won't be able to test multi-platform for a while.
cheers
tim
On Tue, Mar 20, 2012 at 9:49 PM, Mladen Turk <mt...@apache.org> wrote:
> Hi,
>
> Apache Tomcat Connectors 1.2.34 release candidate is ready
> for vote at [1]. This version solves regression(s) found in
> released version 1.2.33 and one long lasting IIS shared memory
> synchronization bug.
>
> The VOTE will remain open for at least 48 hours.
>
> The Apache Tomcat Connectors 1.2.34 is
> [ ] Stable, go ahead and release
> [ ] Broken because of ...
>
>
>
> [1] http://people.apache.org/~mturk/tomcat-connectors/jk-1.2.34/
>
>
> Regards
> --
> ^TM
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Connectors 1.2.34
Posted by Filip Hanik Mailing Lists <de...@hanik.com>.
> [X] Stable, go ahead and release
----- Original Message -----
> From: "Henri Gomez" <he...@gmail.com>
> To: "Tomcat Developers List" <de...@tomcat.apache.org>
> Sent: Wednesday, March 21, 2012 2:33:58 AM
> Subject: Re: [VOTE] Release Apache Tomcat Connectors 1.2.34
>
> > The Apache Tomcat Connectors 1.2.34 is
> > [X] Stable, go ahead and release
> > [ ] Broken because of ...
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Connectors 1.2.34
Posted by Henri Gomez <he...@gmail.com>.
> The Apache Tomcat Connectors 1.2.34 is
> [X] Stable, go ahead and release
> [ ] Broken because of ...
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org