You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "ekaterinadimitrova2 (via GitHub)" <gi...@apache.org> on 2024/04/29 22:05:33 UTC
Re: [PR] Remove error test already covered by unit tests for CASSANDRA-19341 [cassandra-dtest]
ekaterinadimitrova2 commented on code in PR #259:
URL: https://github.com/apache/cassandra-dtest/pull/259#discussion_r1583835086
##########
cql_test.py:
##########
@@ -1219,12 +1219,6 @@ def _assert_logs_slow_queries_with_skinny_table(node, session):
TestCQLSlowQuery._assert_logs(node, session, table,
query="SELECT * FROM {} WHERE k >= 0 AND k < 100 ALLOW FILTERING",
logged_query="SELECT \* FROM ks.{} WHERE k >= 0 AND k < 100")
- TestCQLSlowQuery._assert_logs(node, session, table,
- query="SELECT * FROM {} WHERE k <= 100 AND k > 0 ALLOW FILTERING",
- logged_query="SELECT \* FROM ks.{} WHERE k > 0 AND k <= 100")
- TestCQLSlowQuery._assert_logs(node, session, table,
- query="SELECT * FROM {} WHERE k < 100 AND k >= 0 ALLOW FILTERING",
- logged_query="SELECT \* FROM ks.{} WHERE k >= 0 AND k < 100")
Review Comment:
So technically, now we preserve the restrictions order, and we can fix the two `logged_query.`?
I am wondering why you decided to remove the two assertions instead. This test covered some wrong logging reported in CASSANDRA-15503. Maybe it is better to keep those assertions to ensure no future regressions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org