[jira] [Commented] (KYLIN-3105) Interface Scheduler's stop method should be removed

["jiatao.tao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16290419#comment-16290419 ] 

jiatao.tao commented on KYLIN-3105:
-----------------------------------

we already have shutdown() and hasStarted() method, stop method is useless, and it's implementation is meaningless and ugly like:
DefaultScheduler && DistributedScheduler
{code:java}
// Some comments here
    @Override
    public boolean stop(AbstractExecutable executable) throws SchedulerException {
        if (hasStarted) {
            return true;
        } else {
            //TODO should try to stop this executable
            return true;
        }
    }
{code}



> Interface Scheduler's stop method should be removed
> ---------------------------------------------------
>
>                 Key: KYLIN-3105
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3105
>             Project: Kylin
>          Issue Type: Improvement
>            Reporter: jiatao.tao
>            Assignee: jiatao.tao
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)