You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "git-hulk (via GitHub)" <gi...@apache.org> on 2023/08/11 15:26:19 UTC
[GitHub] [kvrocks] git-hulk opened a new pull request, #1669: Fix data dace when closing the server close in Go tests
git-hulk opened a new pull request, #1669:
URL: https://github.com/apache/kvrocks/pull/1669
Currently, the Kvrocks server close will wait for the process to be exited or until the grace period(30s). And there's a data race between the close function and the timer expired function. We need to wait for the timer's expired routine if it's fired.
This closes #1647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] mapleFU commented on pull request #1669: Fix data dace when closing the server close in Go tests
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #1669:
URL: https://github.com/apache/kvrocks/pull/1669#issuecomment-1675052081
Oh I get it. `Kill` is just for timeout handling. And most of time it will not happen.
When it start to `Kill`, we expect a graceful shutdown?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] tisonkun merged pull request #1669: Fix data dace when closing the server close in Go tests
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #1669:
URL: https://github.com/apache/kvrocks/pull/1669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] mapleFU commented on pull request #1669: Fix data dace when closing the server close in Go tests
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #1669:
URL: https://github.com/apache/kvrocks/pull/1669#issuecomment-1675114599
Oh got it! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] tisonkun commented on pull request #1669: Fix data dace when closing the server close in Go tests
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #1669:
URL: https://github.com/apache/kvrocks/pull/1669#issuecomment-1675081293
> When it start to Kill, we expect a graceful shutdown?
No. It's a final guard to ensure we do not leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] git-hulk commented on pull request #1669: Fix data dace when closing the server close in Go tests
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #1669:
URL: https://github.com/apache/kvrocks/pull/1669#issuecomment-1675026241
> So it's because the syntax of `Stop` ? ( https://pkg.go.dev/time#Timer.Stop )
>
> What would happen if `Kill` never starts?
There're two issues:
1. data race between the close routine and the time-expired routine, the close routine was finished but the timer function was fired, then will expect the kill operation succeeded.
2. The time-expired routine may be panic if the main routine didn't wait for it, refer to the comment: https://github.com/apache/kvrocks/issues/1647#issuecomment-1670595129
> What would happen if `Kill` never starts?
For the most of time, the kill operation shouldn't be started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org