You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2014/11/18 05:14:24 UTC
Review Request 28158: Wired up task parameters in slave
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28158/
-----------------------------------------------------------
Review request for mesos and Timothy Chen.
Bugs: MESOS-2120
https://issues.apache.org/jira/browse/MESOS-2120
Repository: mesos-git
Description
-------
See description.
Diffs
-----
src/common/protobuf_utils.cpp e3e430d321ef472705b8a6218c761ac6cb5f4ba6
src/tests/slave_tests.cpp 18ff8fe499943d209549d9924558d6e84ce78fec
Diff: https://reviews.apache.org/r/28158/diff/
Testing
-------
make check (new test SlaveTest.TaskParameter added)
Thanks,
Niklas Nielsen
Re: Review Request 28158: Wired up task labels in slave
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28158/#review62064
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Nov. 19, 2014, 12:08 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28158/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2014, 12:08 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-2120
> https://issues.apache.org/jira/browse/MESOS-2120
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See description.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp e3e430d321ef472705b8a6218c761ac6cb5f4ba6
> src/tests/slave_tests.cpp 18ff8fe499943d209549d9924558d6e84ce78fec
>
> Diff: https://reviews.apache.org/r/28158/diff/
>
>
> Testing
> -------
>
> make check (new test SlaveTest.TaskLabel added)
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 28158: Wired up task labels in slave
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28158/
-----------------------------------------------------------
(Updated Nov. 18, 2014, 4:08 p.m.)
Review request for mesos and Timothy Chen.
Bugs: MESOS-2120
https://issues.apache.org/jira/browse/MESOS-2120
Repository: mesos-git
Description
-------
See description.
Diffs (updated)
-----
src/common/protobuf_utils.cpp e3e430d321ef472705b8a6218c761ac6cb5f4ba6
src/tests/slave_tests.cpp 18ff8fe499943d209549d9924558d6e84ce78fec
Diff: https://reviews.apache.org/r/28158/diff/
Testing
-------
make check (new test SlaveTest.TaskLabel added)
Thanks,
Niklas Nielsen
Re: Review Request 28158: Wired up task labels in slave
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28158/#review62041
-----------------------------------------------------------
src/tests/slave_tests.cpp
<https://reviews.apache.org/r/28158/#comment103978>
s/> >/>>/g, and all other places.
src/tests/slave_tests.cpp
<https://reviews.apache.org/r/28158/#comment103979>
Test multiple values with the same key.
- Timothy Chen
On Nov. 18, 2014, 10:40 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28158/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2014, 10:40 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-2120
> https://issues.apache.org/jira/browse/MESOS-2120
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See description.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp e3e430d321ef472705b8a6218c761ac6cb5f4ba6
> src/tests/slave_tests.cpp 18ff8fe499943d209549d9924558d6e84ce78fec
>
> Diff: https://reviews.apache.org/r/28158/diff/
>
>
> Testing
> -------
>
> make check (new test SlaveTest.TaskLabel added)
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 28158: Wired up task labels in slave
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28158/
-----------------------------------------------------------
(Updated Nov. 18, 2014, 2:40 p.m.)
Review request for mesos and Timothy Chen.
Summary (updated)
-----------------
Wired up task labels in slave
Bugs: MESOS-2120
https://issues.apache.org/jira/browse/MESOS-2120
Repository: mesos-git
Description
-------
See description.
Diffs (updated)
-----
src/common/protobuf_utils.cpp e3e430d321ef472705b8a6218c761ac6cb5f4ba6
src/tests/slave_tests.cpp 18ff8fe499943d209549d9924558d6e84ce78fec
Diff: https://reviews.apache.org/r/28158/diff/
Testing (updated)
-------
make check (new test SlaveTest.TaskLabel added)
Thanks,
Niklas Nielsen