You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/02/11 22:19:08 UTC
[PR] remove compatibility test [incubator-pekko-grpc]
pjfanning opened a new pull request, #229:
URL: https://github.com/apache/incubator-pekko-grpc/pull/229
this test blocks #222 and it isn't a core feature
#228 is about writing a new test to replace this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] remove compatibility test [incubator-pekko-grpc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #229:
URL: https://github.com/apache/incubator-pekko-grpc/pull/229#issuecomment-1938286953
@raboof to flip the question - is it worth blocking the upgrade of the grpc and protobuf libs until someone works out how to fix this test? https://github.com/apache/incubator-pekko-grpc/issues/228 is there to remind us that we need to add this or an equivalent test back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] remove compatibility test [incubator-pekko-grpc]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on PR #229:
URL: https://github.com/apache/incubator-pekko-grpc/pull/229#issuecomment-1938272912
Looking at https://github.com/protocolbuffers/protobuf-javascript/issues/127#issuecomment-1542288860 are we sure it's impossible to make this work with newer versions of protobuf?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] remove compatibility test [incubator-pekko-grpc]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on PR #229:
URL: https://github.com/apache/incubator-pekko-grpc/pull/229#issuecomment-1955228675
superseded by #222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] remove compatibility test [incubator-pekko-grpc]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on PR #229:
URL: https://github.com/apache/incubator-pekko-grpc/pull/229#issuecomment-1938340489
> #228 is there to remind us that we need to add this or an equivalent test back.
TBH I'm not optimistic that that would actually happen when there's no pressing need anymore ;)
> @raboof to flip the question - is it worth blocking the upgrade of the grpc and protobuf libs until someone works out how to fix this test?
It seems we are fairly close... let's give it a week?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] remove compatibility test [incubator-pekko-grpc]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof closed pull request #229: remove compatibility test
URL: https://github.com/apache/incubator-pekko-grpc/pull/229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org