You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Harsh J (JIRA)" <ji...@apache.org> on 2012/12/02 05:39:58 UTC

[jira] [Created] (HDFS-4259) Improve pipeline DN replacement failure message

Harsh J created HDFS-4259:
-----------------------------

             Summary: Improve pipeline DN replacement failure message
                 Key: HDFS-4259
                 URL: https://issues.apache.org/jira/browse/HDFS-4259
             Project: Hadoop HDFS
          Issue Type: Improvement
          Components: hdfs-client
    Affects Versions: 2.0.2-alpha
            Reporter: Harsh J
            Priority: Minor


The current message shown is something such as below:

bq. Failed to add a datanode. User may turn off this feature by setting X.policy in configuration, where the current policy is Y. (Nodes: current=[foo], original=[bar])

This reads off like failing is a feature (but the intention and the reason we hit this isn't indicated strongly), and can be bettered.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4259) Improve pipeline DN replacement failure message

Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509427#comment-13509427 ] 

Aaron T. Myers commented on HDFS-4259:
--------------------------------------

+1, the patch looks good to me. I agree that this is an improvement to the error message that should hopefully decrease confusion when folks see it.
                
> Improve pipeline DN replacement failure message
> -----------------------------------------------
>
>                 Key: HDFS-4259
>                 URL: https://issues.apache.org/jira/browse/HDFS-4259
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>    Affects Versions: 2.0.2-alpha
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HDFS-4259.patch
>
>
> The current message shown is something such as below:
> bq. Failed to add a datanode. User may turn off this feature by setting X.policy in configuration, where the current policy is Y. (Nodes: current=\[foo\], original=\[bar\])
> This reads off like failing is a feature (but the intention and the reason we hit this isn't indicated strongly), and can be bettered.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4259) Improve pipeline DN replacement failure message

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508180#comment-13508180 ] 

Hadoop QA commented on HDFS-4259:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12555661/HDFS-4259.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3588//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3588//console

This message is automatically generated.
                
> Improve pipeline DN replacement failure message
> -----------------------------------------------
>
>                 Key: HDFS-4259
>                 URL: https://issues.apache.org/jira/browse/HDFS-4259
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>    Affects Versions: 2.0.2-alpha
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HDFS-4259.patch
>
>
> The current message shown is something such as below:
> bq. Failed to add a datanode. User may turn off this feature by setting X.policy in configuration, where the current policy is Y. (Nodes: current=\[foo\], original=\[bar\])
> This reads off like failing is a feature (but the intention and the reason we hit this isn't indicated strongly), and can be bettered.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (HDFS-4259) Improve pipeline DN replacement failure message

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J reassigned HDFS-4259:
-----------------------------

    Assignee: Harsh J
    
> Improve pipeline DN replacement failure message
> -----------------------------------------------
>
>                 Key: HDFS-4259
>                 URL: https://issues.apache.org/jira/browse/HDFS-4259
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>    Affects Versions: 2.0.2-alpha
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HDFS-4259.patch
>
>
> The current message shown is something such as below:
> bq. Failed to add a datanode. User may turn off this feature by setting X.policy in configuration, where the current policy is Y. (Nodes: current=\[foo\], original=\[bar\])
> This reads off like failing is a feature (but the intention and the reason we hit this isn't indicated strongly), and can be bettered.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-4259) Improve pipeline DN replacement failure message

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HDFS-4259:
--------------------------

    Description: 
The current message shown is something such as below:

bq. Failed to add a datanode. User may turn off this feature by setting X.policy in configuration, where the current policy is Y. (Nodes: current=\[foo\], original=\[bar\])

This reads off like failing is a feature (but the intention and the reason we hit this isn't indicated strongly), and can be bettered.

  was:
The current message shown is something such as below:

bq. Failed to add a datanode. User may turn off this feature by setting X.policy in configuration, where the current policy is Y. (Nodes: current=[foo], original=[bar])

This reads off like failing is a feature (but the intention and the reason we hit this isn't indicated strongly), and can be bettered.

    
> Improve pipeline DN replacement failure message
> -----------------------------------------------
>
>                 Key: HDFS-4259
>                 URL: https://issues.apache.org/jira/browse/HDFS-4259
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>    Affects Versions: 2.0.2-alpha
>            Reporter: Harsh J
>            Priority: Minor
>         Attachments: HDFS-4259.patch
>
>
> The current message shown is something such as below:
> bq. Failed to add a datanode. User may turn off this feature by setting X.policy in configuration, where the current policy is Y. (Nodes: current=\[foo\], original=\[bar\])
> This reads off like failing is a feature (but the intention and the reason we hit this isn't indicated strongly), and can be bettered.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4259) Improve pipeline DN replacement failure message

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508358#comment-13508358 ] 

Harsh J commented on HDFS-4259:
-------------------------------

bq. -1 tests included. The patch doesn't appear to include any new or modified tests.
bq. Please justify why no new tests are needed for this patch.
bq. Also please list what manual steps were performed to verify this patch.

The patch merely changes an error message to make it more understandable for ops.
                
> Improve pipeline DN replacement failure message
> -----------------------------------------------
>
>                 Key: HDFS-4259
>                 URL: https://issues.apache.org/jira/browse/HDFS-4259
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>    Affects Versions: 2.0.2-alpha
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HDFS-4259.patch
>
>
> The current message shown is something such as below:
> bq. Failed to add a datanode. User may turn off this feature by setting X.policy in configuration, where the current policy is Y. (Nodes: current=\[foo\], original=\[bar\])
> This reads off like failing is a feature (but the intention and the reason we hit this isn't indicated strongly), and can be bettered.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-4259) Improve pipeline DN replacement failure message

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HDFS-4259:
--------------------------

    Target Version/s: 3.0.0
    
> Improve pipeline DN replacement failure message
> -----------------------------------------------
>
>                 Key: HDFS-4259
>                 URL: https://issues.apache.org/jira/browse/HDFS-4259
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>    Affects Versions: 2.0.2-alpha
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HDFS-4259.patch
>
>
> The current message shown is something such as below:
> bq. Failed to add a datanode. User may turn off this feature by setting X.policy in configuration, where the current policy is Y. (Nodes: current=\[foo\], original=\[bar\])
> This reads off like failing is a feature (but the intention and the reason we hit this isn't indicated strongly), and can be bettered.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-4259) Improve pipeline DN replacement failure message

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HDFS-4259:
--------------------------

    Status: Patch Available  (was: Open)
    
> Improve pipeline DN replacement failure message
> -----------------------------------------------
>
>                 Key: HDFS-4259
>                 URL: https://issues.apache.org/jira/browse/HDFS-4259
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>    Affects Versions: 2.0.2-alpha
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HDFS-4259.patch
>
>
> The current message shown is something such as below:
> bq. Failed to add a datanode. User may turn off this feature by setting X.policy in configuration, where the current policy is Y. (Nodes: current=\[foo\], original=\[bar\])
> This reads off like failing is a feature (but the intention and the reason we hit this isn't indicated strongly), and can be bettered.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-4259) Improve pipeline DN replacement failure message

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HDFS-4259:
--------------------------

    Attachment: HDFS-4259.patch

Here's a patch that changes it to:

bq. Failed to replace a bad datanode on the existing pipeline due to no more good datanodes being available to try. (Nodes: current=[foo], original=[bar]). The current failed datanode replacement policy is Y, and a client may configure this via 'X.policy' in its configuration.
                
> Improve pipeline DN replacement failure message
> -----------------------------------------------
>
>                 Key: HDFS-4259
>                 URL: https://issues.apache.org/jira/browse/HDFS-4259
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>    Affects Versions: 2.0.2-alpha
>            Reporter: Harsh J
>            Priority: Minor
>         Attachments: HDFS-4259.patch
>
>
> The current message shown is something such as below:
> bq. Failed to add a datanode. User may turn off this feature by setting X.policy in configuration, where the current policy is Y. (Nodes: current=[foo], original=[bar])
> This reads off like failing is a feature (but the intention and the reason we hit this isn't indicated strongly), and can be bettered.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira