[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #271: [FLINK-27820] Handle deployment errors on observe

[GitBox <gi...@apache.org>]

gyfora commented on code in PR #271:
URL: https://github.com/apache/flink-kubernetes-operator/pull/271#discussion_r901587462


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java:
##########
@@ -252,6 +257,60 @@ private void onMissingDeployment(FlinkDeployment deployment) {
                 EventUtils.Component.JobManagerDeployment);
     }
 
+    /**
+     * Checks a deployment that is currently in the UPGRADING state whether it was already deployed
+     * but we simply miss the status information. After comparing the target resource generation
+     * with the one from the possible deployment if they match we update the status to the already
+     * DEPLOYED state.
+     *
+     * @param flinkDep Flink resource to check.
+     * @param context Context for reconciliation.
+     */
+    private void checkIfAlreadyUpgraded(FlinkDeployment flinkDep, Context context) {

Review Comment:
   Well this check specifically checks if an UPGRADING deployment is already upgraded. Calling it sync would give the impression that it does something more.
   
   Also it's not really problematic to introduce a new DEPLOYING state but it would add no value so I would prefer not do it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org