You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/03/03 00:26:49 UTC
[GitHub] [incubator-pinot] jackjlli opened a new pull request #6631: Shade jackson packages in pinot-spi and pinot-avro-base modules
jackjlli opened a new pull request #6631:
URL: https://github.com/apache/incubator-pinot/pull/6631
## Description
This PR shades jackson packages in pinot-spi and pinot-avro-base modules, as we encounter version conflicts.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
## Release Notes
If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release.
If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text
## Documentation
If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6631: Shade jackson packages in pinot-spi and pinot-avro-base modules
Posted by GitBox <gi...@apache.org>.
jackjlli commented on a change in pull request #6631:
URL: https://github.com/apache/incubator-pinot/pull/6631#discussion_r586019895
##########
File path: pinot-spi/pom.xml
##########
@@ -171,6 +171,10 @@
<pattern>com.google.common.base</pattern>
<shadedPattern>shaded.com.google.common.base</shadedPattern>
</relocation>
+ <relocation>
Review comment:
pinot-avro-base internally depends on pinot-spi. If we don't shade both, pinot-common would still be pulled. Thus, have to shade two modules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io commented on pull request #6631: Shade jackson packages in pinot-spi and pinot-avro-base modules
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #6631:
URL: https://github.com/apache/incubator-pinot/pull/6631#issuecomment-789348572
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6631?src=pr&el=h1) Report
> Merging [#6631](https://codecov.io/gh/apache/incubator-pinot/pull/6631?src=pr&el=desc) (ef4a041) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a?el=desc) (1beaab5) will **decrease** coverage by `0.63%`.
> The diff coverage is `62.64%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/6631?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6631 +/- ##
==========================================
- Coverage 66.44% 65.81% -0.64%
==========================================
Files 1075 1360 +285
Lines 54773 66535 +11762
Branches 8168 9698 +1530
==========================================
+ Hits 36396 43789 +7393
- Misses 15700 19621 +3921
- Partials 2677 3125 +448
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `65.81% <62.64%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/6631?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...e/pinot/broker/api/resources/PinotBrokerDebug.java](https://codecov.io/gh/apache/incubator-pinot/pull/6631/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYXBpL3Jlc291cmNlcy9QaW5vdEJyb2tlckRlYnVnLmphdmE=) | `0.00% <0.00%> (-79.32%)` | :arrow_down: |
| [...pinot/broker/api/resources/PinotClientRequest.java](https://codecov.io/gh/apache/incubator-pinot/pull/6631/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYXBpL3Jlc291cmNlcy9QaW5vdENsaWVudFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-27.28%)` | :arrow_down: |
| [...ot/broker/broker/AllowAllAccessControlFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6631/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0FsbG93QWxsQWNjZXNzQ29udHJvbEZhY3RvcnkuamF2YQ==) | `71.42% <ø> (-28.58%)` | :arrow_down: |
| [.../helix/BrokerUserDefinedMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6631/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0Jyb2tlclVzZXJEZWZpbmVkTWVzc2FnZUhhbmRsZXJGYWN0b3J5LmphdmE=) | `33.96% <0.00%> (-32.71%)` | :arrow_down: |
| [...ker/routing/instanceselector/InstanceSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/6631/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9pbnN0YW5jZXNlbGVjdG9yL0luc3RhbmNlU2VsZWN0b3IuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ava/org/apache/pinot/client/AbstractResultSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/6631/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Fic3RyYWN0UmVzdWx0U2V0LmphdmE=) | `66.66% <ø> (+9.52%)` | :arrow_up: |
| [...n/java/org/apache/pinot/client/BrokerResponse.java](https://codecov.io/gh/apache/incubator-pinot/pull/6631/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Jyb2tlclJlc3BvbnNlLmphdmE=) | `100.00% <ø> (ø)` | |
| [.../main/java/org/apache/pinot/client/Connection.java](https://codecov.io/gh/apache/incubator-pinot/pull/6631/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Nvbm5lY3Rpb24uamF2YQ==) | `35.55% <ø> (-13.29%)` | :arrow_down: |
| [...org/apache/pinot/client/DynamicBrokerSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/6631/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0R5bmFtaWNCcm9rZXJTZWxlY3Rvci5qYXZh) | `82.85% <ø> (+10.12%)` | :arrow_up: |
| [...n/java/org/apache/pinot/client/ExecutionStats.java](https://codecov.io/gh/apache/incubator-pinot/pull/6631/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0V4ZWN1dGlvblN0YXRzLmphdmE=) | `68.88% <ø> (ø)` | |
| ... and [1243 more](https://codecov.io/gh/apache/incubator-pinot/pull/6631/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6631?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6631?src=pr&el=footer). Last update [a4a05e3...ef4a041](https://codecov.io/gh/apache/incubator-pinot/pull/6631?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6631: Shade jackson packages in pinot-spi and pinot-avro-base modules
Posted by GitBox <gi...@apache.org>.
fx19880617 commented on a change in pull request #6631:
URL: https://github.com/apache/incubator-pinot/pull/6631#discussion_r586012473
##########
File path: pinot-spi/pom.xml
##########
@@ -171,6 +171,10 @@
<pattern>com.google.common.base</pattern>
<shadedPattern>shaded.com.google.common.base</shadedPattern>
</relocation>
+ <relocation>
Review comment:
do we need to shade both?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6631: Shade jackson packages in pinot-spi and pinot-avro-base modules
Posted by GitBox <gi...@apache.org>.
jackjlli commented on a change in pull request #6631:
URL: https://github.com/apache/incubator-pinot/pull/6631#discussion_r586019895
##########
File path: pinot-spi/pom.xml
##########
@@ -171,6 +171,10 @@
<pattern>com.google.common.base</pattern>
<shadedPattern>shaded.com.google.common.base</shadedPattern>
</relocation>
+ <relocation>
Review comment:
pinot-avro-base internally depends on pinot-spi. If we don't shade both, the unshaded jar of pinot-common would still be pulled. Thus, have to shade two modules.
```
[INFO] ------------------< org.apache.pinot:pinot-avro-base >------------------
[INFO] Building Pinot Avro Base 0.7.0-SNAPSHOT [6/48]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ pinot-avro-base ---
[INFO] org.apache.pinot:pinot-avro-base:jar:0.7.0-SNAPSHOT
[INFO] +- org.apache.pinot:pinot-spi:test-jar:tests:0.7.0-SNAPSHOT:test
[INFO] | \- com.fasterxml.jackson.core:jackson-databind:jar:2.10.0:test
[INFO] \- org.apache.pinot:pinot-spi:jar:0.7.0-SNAPSHOT:provided
[INFO] \- (com.fasterxml.jackson.core:jackson-databind:jar:2.10.0:provided - omitted for duplicate)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6631: Shade jackson packages in pinot-spi and pinot-avro-base modules
Posted by GitBox <gi...@apache.org>.
jackjlli commented on a change in pull request #6631:
URL: https://github.com/apache/incubator-pinot/pull/6631#discussion_r586019895
##########
File path: pinot-spi/pom.xml
##########
@@ -171,6 +171,10 @@
<pattern>com.google.common.base</pattern>
<shadedPattern>shaded.com.google.common.base</shadedPattern>
</relocation>
+ <relocation>
Review comment:
pinot-avro-base internally depends on pinot-spi. If we don't shade both, the unshaded jar of pinot-common would still be pulled. Thus, have to shade two modules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli merged pull request #6631: Shade jackson packages in pinot-spi and pinot-avro-base modules
Posted by GitBox <gi...@apache.org>.
jackjlli merged pull request #6631:
URL: https://github.com/apache/incubator-pinot/pull/6631
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6631: Shade jackson packages in pinot-spi and pinot-avro-base modules
Posted by GitBox <gi...@apache.org>.
jackjlli commented on a change in pull request #6631:
URL: https://github.com/apache/incubator-pinot/pull/6631#discussion_r586019895
##########
File path: pinot-spi/pom.xml
##########
@@ -171,6 +171,10 @@
<pattern>com.google.common.base</pattern>
<shadedPattern>shaded.com.google.common.base</shadedPattern>
</relocation>
+ <relocation>
Review comment:
pinot-avro-base internally depends on pinot-spi. If we don't shade both, the unshaded jar of pinot-spi would still be pulled. Thus, have to shade two modules.
```
[INFO] ------------------< org.apache.pinot:pinot-avro-base >------------------
[INFO] Building Pinot Avro Base 0.7.0-SNAPSHOT [6/48]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ pinot-avro-base ---
[INFO] org.apache.pinot:pinot-avro-base:jar:0.7.0-SNAPSHOT
[INFO] +- org.apache.pinot:pinot-spi:test-jar:tests:0.7.0-SNAPSHOT:test
[INFO] | \- com.fasterxml.jackson.core:jackson-databind:jar:2.10.0:test
[INFO] \- org.apache.pinot:pinot-spi:jar:0.7.0-SNAPSHOT:provided
[INFO] \- (com.fasterxml.jackson.core:jackson-databind:jar:2.10.0:provided - omitted for duplicate)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org